[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/8] usb: XHCI shall not halt isochronous endpoints
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 4/8] usb: XHCI shall not halt isochronous endpoints |
Date: |
Wed, 30 Jan 2019 08:34:22 +0100 |
From: Yuri Benditovich <address@hidden>
According to the XHCI spec (4.10.2) the controller
never halts isochronous endpoints. This commit prevent
stop of isochronous streaming when sporadic errors
status received from backends.
Signed-off-by: Yuri Benditovich <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/hcd-xhci.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 8f1a01a405..1a8fd9644e 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -1571,6 +1571,11 @@ static void xhci_stall_ep(XHCITransfer *xfer)
uint32_t err;
XHCIStreamContext *sctx;
+ if (epctx->type == ET_ISO_IN || epctx->type == ET_ISO_OUT) {
+ /* never halt isoch endpoints, 4.10.2 */
+ return;
+ }
+
if (epctx->nr_pstreams) {
sctx = xhci_find_stream(epctx, xfer->streamid, &err);
if (sctx == NULL) {
--
2.9.3
- [Qemu-devel] [PULL 0/8] Usb 20190130 patches, Gerd Hoffmann, 2019/01/30
- [Qemu-devel] [PULL 2/8] usb: dev-mtp: close fd in usb_mtp_object_readdir(), Gerd Hoffmann, 2019/01/30
- [Qemu-devel] [PULL 7/8] usb-mtp: breakup MTP write into smaller chunks, Gerd Hoffmann, 2019/01/30
- [Qemu-devel] [PULL 6/8] usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ, Gerd Hoffmann, 2019/01/30
- [Qemu-devel] [PULL 1/8] usb: assign unique serial numbers to hid devices, Gerd Hoffmann, 2019/01/30
- [Qemu-devel] [PULL 8/8] usb-mtp: replace the homebrew write with qemu_write_full, Gerd Hoffmann, 2019/01/30
- [Qemu-devel] [PULL 4/8] usb: XHCI shall not halt isochronous endpoints,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 5/8] usb: implement XHCI underrun/overrun events, Gerd Hoffmann, 2019/01/30
- [Qemu-devel] [PULL 3/8] hw/usb: Fix LGPL information in the file headers, Gerd Hoffmann, 2019/01/30
- Re: [Qemu-devel] [PULL 0/8] Usb 20190130 patches, Peter Maydell, 2019/01/31
- Re: [Qemu-devel] [PULL 0/8] Usb 20190130 patches, no-reply, 2019/01/31