[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acp
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin |
Date: |
Wed, 30 Jan 2019 09:11:47 +0100 |
On Wed, 30 Jan 2019 08:06:53 +0800
Wei Yang <address@hidden> wrote:
> acpi_table_builtin is now always false, it is not necessary to check it
> again.
>
> This patch just removes it.
>
> Signed-off-by: Wei Yang <address@hidden>
> Reviewed-by: Philippe Mathieu-Daud茅 <address@hidden>
> Tested-by: Philippe Mathieu-Daud茅 <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> hw/acpi/core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index e9b1a85e54..f9c96535d1 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -303,8 +303,6 @@ out:
> error_propagate(errp, err);
> }
>
> -static bool acpi_table_builtin = false;
> -
> unsigned acpi_table_len(void *current)
> {
> struct acpi_table_header *hdr = current - sizeof(hdr->_length);
> @@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)
>
> uint8_t *acpi_table_first(void)
> {
> - if (acpi_table_builtin || !acpi_tables) {
> + if (!acpi_tables) {
> return NULL;
> }
> return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);