[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci
Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file
Thu, 31 Jan 2019 19:08:39 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1
On 31/01/19 19:00, Thomas Huth wrote:
>>> (and the prototypes in the header) anymore, so if you try to compile s390x
>>> without CONFIG_PCI, the build currently fails.
>> Fixes: 468a93898a97 ("s390x/pci: pass the retaddr to all PCI instructions")
>>> Signed-off-by: Thomas Huth <address@hidden>
>>> hw/s390x/s390-pci-stub.c | 16 +++++++++-------
>>> 1 file changed, 9 insertions(+), 7 deletions(-)
>> This file seems to be in danger of bitrot. Do you think it'll be easier
>> to test rarely used configs like that after we switch to Kconfig?
> I hope so, yes. There will be a new --without-default-devices options
> for "configure" (which matches "make allnoconfig" from the kernel) - if
> we do it right in the Kconfig file for s390x, it should be possible to
> catch this problem with that option.
Yes, it will be in .travis.yml too.
Right now there is a "select PCI" in the hw/s390x/Kconfig file, but
probably it's best to add a config S390_ZPCI with "default y if
S390_CCW_VIRTIO" and "select PCI" in it. Not a blocker, but I can
integrate it if you send me a fixup patch.