Re: [Qemu-devel] [PATCH 0/5] misc fixes to deal with icon location changes

[Daniel P . Berrangé]

On Fri, Feb 01, 2019 at 08:52:25AM +0100, Stefan Weil wrote:
> On 29.01.19 12:39, Daniel P. Berrangé wrote:
> > This is a few misc fixes identified after the icon location changes
> > were merged. Most importantly it deals with the nsis installer file
> > manifest.
> > 
> > Daniel P. Berrangé (5):
> >   nsis: don't install files into /tmp
> >   make: don't insert a '/' after $(DESTDIR)
> >   nsis: ensure we always pass -W64 flag to nsis installer script
> >   nsis: fix location of icons to be bundled in the installer
> >   configure: stop trying to link non-existant bmp file from bios dir
> > 
> >  Makefile  | 23 +++++++++++++----------
> >  configure |  1 -
> >  qemu.nsi  |  4 ++--
> >  3 files changed, 15 insertions(+), 13 deletions(-)
> > 
> 
> There was also a file rename which needs to be handled,
> otherwise NSIS still fails:
> 
> File: "/tmp/qemu-nsis\qemu_logo_no_text.svg" -> no files found.

I don't see that prolem - NSIS builds successfully for me, and I can't
find any reference to .svg files in the qemu.nsi 

> The new qemu.svg still includes the old file name. That could be fixed, too.

Oh, in its metadata I see.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|