Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

[Peter Maydell]

On Mon, 4 Feb 2019 at 14:43, Michael S. Tsirkin <address@hidden> wrote:
>
> The following changes since commit b3fc0af1ff5e922d4dd7c875394dbd26dc7313b4:
>
>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging 
> (2019-02-01 17:58:27 +0000)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 5feab30ea98e30446361d184331b7b5ff94b4116:
>
>   contrib/libvhost-user: cleanup casts (2019-02-04 09:23:56 -0500)
>
> ----------------------------------------------------------------
> pci, pc, virtio: fixes, cleanups, features
>
> vhost user blk discard/write zeroes features
> misc cleanups and fixes all over the place
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>

Hi; I'm afraid this failed build/test on various platforms.


Format string issues on ppc64 host:

/home/pm215/qemu/contrib/libvhost-user/libvhost-user.c: In function
‘vu_set_mem_table_exec_postcopy’:
/home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:636:9: error:
format ‘%llx’ expects argument of type ‘long long unsigned int’, but
argument 5 has type ‘__u64’ [-Werror=format=]
         DPRINT("%s: region %d: Registered userfault for %llx + %llx\n",
         ^
/home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:636:9: error:
format ‘%llx’ expects argument of type ‘long long unsigned int’, but
argument 6 has type ‘__u64’ [-Werror=format=]


Compilation failure on 32-bit:

/home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c: In
function 'vu_set_mem_table_exec_postcopy':
/home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c:594:23:
error: cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]
         ret = madvise((void *)dev_region->mmap_addr,
                       ^
/home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c:606:23:
error: cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]
         ret = madvise((void *)dev_region->mmap_addr,
                       ^
/home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c:639:22:
error: cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]
         if (mprotect((void *)dev_region->mmap_addr,
                      ^


More format string issues on 32-bit:

/home/peter.maydell/qemu/contrib/vhost-user-blk/vhost-user-blk.c: In
function 'vub_readv':
/home/peter.maydell/qemu/contrib/vhost-user-blk/vhost-user-blk.c:146:25:
error: format '%lu' expects argument of type 'long unsigned int', but
argument 5 has type 'size_t {aka unsigned int}' [-Werror=format=]
         fprintf(stderr, "%s, Sector %"PRIu64", Size %lu failed with %s\n",
                         ^
/home/peter.maydell/qemu/contrib/vhost-user-blk/vhost-user-blk.c: In
function 'vub_writev':
/home/peter.maydell/qemu/contrib/vhost-user-blk/vhost-user-blk.c:169:25:
error: format '%lu' expects argument of type 'long unsigned int', but
argument 5 has type 'size_t {aka unsigned int}' [-Werror=format=]
         fprintf(stderr, "%s, Sector %"PRIu64", Size %lu failed with %s\n",
                         ^
/home/peter.maydell/qemu/contrib/vhost-user-blk/vhost-user-blk.c: In
function 'vub_discard_write_zeroes':
/home/peter.maydell/qemu/contrib/vhost-user-blk/vhost-user-blk.c:188:25:
error: format '%ld' expects argument of type 'long int', but argument
3 has type 'ssize_t {aka int}' [-Werror=format=]
         fprintf(stderr, "Invalid size %ld, expect %ld\n", size, sizeof(*desc));
                         ^
/home/peter.maydell/qemu/contrib/vhost-user-blk/vhost-user-blk.c:188:25:
error: format '%ld' expects argument of type 'long int', but argument
4 has type 'unsigned int' [-Werror=format=]


Compiler warning in a test case on the BSDs and OSX:

tests/vhost-user-test.c: In function 'main':
tests/vhost-user-test.c:942:17: warning: unused variable 'hugefs'
[-Wunused-variable]
     const char *hugefs;
                 ^


Test failures on sparc host due to an assert:

ERROR:/home/pm215/qemu/tests/vhost-user-test.c:243:wait_for_fds:
assertion failed: (s->fds_num)
Aborted

and the same on s390x, with a bit more detail:

MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386
QTEST_QEMU_IMG=qemu-img tests/vhost-user-test -m=quick -k --tap <
/dev/null | ./scripts/tap-driver.pl --test-name="vhost-user-test"
qemu-system-i386: backend does not support LE vnet headers; falling
back on userspace virtio
qemu-system-i386: backend does not support LE vnet headers; falling
back on userspace virtio
**
ERROR:/home/linux1/qemu/tests/vhost-user-test.c:243:wait_for_fds:
assertion failed: (s->fds_num)
Aborted (core dumped)
ERROR - too few tests run (expected 4, got 0)
/home/linux1/qemu/tests/Makefile.include:858: recipe for target
'check-qtest-i386' failed


New warnings about taking address of packed member on the clang
build: these aren't compile failures but we are very close to being
able to make them compile failures, so please don't add new ones:

/home/petmay01/linaro/qemu-for-merges/contrib/libvhost-user/libvhost-user.c:515:32:
warning: taking address
 of packed member 'payload' of class or structure 'VhostUserMsg' may
result in an unaligned pointer value [
-Waddress-of-packed-member]
    VhostUserMemory *memory = &vmsg->payload.memory;
                               ^~~~~~~~~~~~~~~~~~~~
/home/petmay01/linaro/qemu-for-merges/contrib/libvhost-user/libvhost-user.c:657:32:
warning: taking address
 of packed member 'payload' of class or structure 'VhostUserMsg' may
result in an unaligned pointer value [
-Waddress-of-packed-member]
    VhostUserMemory *memory = &vmsg->payload.memory;
                               ^~~~~~~~~~~~~~~~~~~~
/home/petmay01/linaro/qemu-for-merges/contrib/libvhost-user/libvhost-user.c:786:37:
warning: taking address
 of packed member 'payload' of class or structure 'VhostUserMsg' may
result in an unaligned pointer value [
-Waddress-of-packed-member]
    struct vhost_vring_addr *vra = &vmsg->payload.addr;
                                    ^~~~~~~~~~~~~~~~~~


Compile error on the clang build:

/home/petmay01/linaro/qemu-for-merges/contrib/libvhost-user/libvhost-user.c:953:20:
error: implicit conversion from enumeration type 'enum
VhostUserSlaveRequest' to different enumeration type
'VhostUserRequest' (aka 'enum VhostUserRequest')
[-Werror,-Wenum-conversion]
        .request = VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG,
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


thanks
-- PMM