[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 41/77] i386: hvf: Don't miss 16-bit displacement
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 41/77] i386: hvf: Don't miss 16-bit displacement |
Date: |
Mon, 4 Feb 2019 19:35:43 +0100 |
From: Roman Bolshakov <address@hidden>
In 16-bit addressing mode, when Mod = 0 and R/M = 6, decoded displacement
doesn't reach decode_linear_addr and gets lost. Instructions that
involve the combination of ModRM always get a pointer with zero offset
from the beginning of DS segment.
The change fixes drawing in F-BIRD from day 1 of '18 advent calendar.
Signed-off-by: Roman Bolshakov <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
target/i386/hvf/x86_decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c
index 5f513c5..9ef7d75 100644
--- a/target/i386/hvf/x86_decode.c
+++ b/target/i386/hvf/x86_decode.c
@@ -1642,7 +1642,7 @@ void calc_modrm_operand16(CPUX86State *env, struct
x86_decode *decode,
X86Seg seg = R_DS;
if (!decode->modrm.mod && 6 == decode->modrm.rm) {
- op->ptr = (uint16_t)decode->displacement;
+ ptr = decode->displacement;
goto calc_addr;
}
--
1.8.3.1
- [Qemu-devel] [PULL 27/77] contrib/elf2dmp: fix elf.h including, (continued)
- [Qemu-devel] [PULL 27/77] contrib/elf2dmp: fix elf.h including, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 15/77] pvh: Boot uncompressed kernel using direct boot ABI, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 37/77] hw/core/loader.c: Read as long as possible in load_image_size(), Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 40/77] docker: adjust Xen repository for CentOS 7, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 33/77] monitor: do not use QTAILQ_FOREACH_SAFE across critical sections, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 38/77] i386: import & use bootparam.h, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 36/77] unify len and addr type for memory/address APIs, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 34/77] crypto: finish removing TABs, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 39/77] i386: allow to load initrd below 4 GB for recent linux, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 35/77] ui: vnc: finish removing TABs, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 41/77] i386: hvf: Don't miss 16-bit displacement,
Paolo Bonzini <=
- [Qemu-devel] [PULL 43/77] scsi-generic: avoid possible out-of-bounds access to r->buf, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 42/77] gdbstub: Fix i386/x86_64 machine description and add control registers, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 48/77] vfio: move conditional up to hw/Makefile.objs, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 44/77] Remove deprecated -enable-hax option, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 46/77] arm: disable CONFIG_SERIAL_ISA, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 49/77] hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 47/77] ide: split ioport registration to a separate file, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 45/77] qemu-options: Remove deprecated "-virtioconsole" option, Paolo Bonzini, 2019/02/04
- [Qemu-devel] [PULL 50/77] build: actually use CONFIG_PAM, Paolo Bonzini, 2019/02/04