[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] mips: Express dependencies of the Loongson
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 6/6] mips: Express dependencies of the Loongson 2E machine with kconfig |
Date: |
Mon, 4 Feb 2019 21:16:13 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Thomas,
On 2/4/19 9:46 AM, Thomas Huth wrote:
> On 2019-02-03 23:07, Philippe Mathieu-Daudé wrote:
>> The Loongson 2E uses a Bonito64 system controller as North Bridge and a
>> VT82C686 chipset as South Bridge. The network card chipset is a RTL8139D.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
> [...]
>> diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
>> index 2940ff39ab..16b2bdb068 100644
>> --- a/hw/mips/Kconfig
>> +++ b/hw/mips/Kconfig
>> @@ -42,6 +42,11 @@ config JAZZ
>>
>> config FULONG
>> bool
>> + select PCI_BONITO
>> + select VT82C686
>> + select SMBUS_EEPROM
>> + select RTL8139_PCI
>
> If I've got the code right, the RTL8139 is optional for this board, i.e.
> when you run with -nodefaults or -net none, then the board is still
> usable. So this is not a hard requirement and thus I think it would be
> nicer to drop the "select RTL8139_PCI" and rely on the "default y if
> PCI_DEVICES" in the hw/net/Kconfig file.
I think since his introduction (051c190bce59) the code wants to deal
with no network backend, but the RTL8139D is always available.
On this picture you can se the chipset soldered on the back of the
board: https://www.linux-mips.org/wiki/Fulong#back
I'll keep the RTL8139_PCI selection and eventually propose a patch to
clean the hw/mips/mips_fulong2e.c.
Thanks for your other reviews!
Phil.
- Re: [Qemu-devel] [PATCH 1/6] mips: Express dependencies of the MIPSsim machine with kconfig, (continued)
- [Qemu-devel] [PATCH 2/6] mips: Express dependencies of the Jazz machine with kconfig, Philippe Mathieu-Daudé, 2019/02/03
- [Qemu-devel] [PATCH 3/6] mips: Express dependencies of the r4k platform with kconfig, Philippe Mathieu-Daudé, 2019/02/03
- [Qemu-devel] [PATCH 4/6] mips: Express dependencies of the Boston machine with kconfig, Philippe Mathieu-Daudé, 2019/02/03
- [Qemu-devel] [PATCH 5/6] hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge, Philippe Mathieu-Daudé, 2019/02/03
- [Qemu-devel] [PATCH 6/6] mips: Express dependencies of the Loongson 2E machine with kconfig, Philippe Mathieu-Daudé, 2019/02/03
- Re: [Qemu-devel] [PATCH 0/6] Kconfig dependencies for MIPS machines (but Malta), Philippe Mathieu-Daudé, 2019/02/03