[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements |
Date: |
Wed, 6 Feb 2019 03:37:50 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/5/19 9:29 PM, Mark Cave-Ayland wrote:
> The only minor question I had with the patchset in its current form is
> whether to use
> the new VsrD() macro for vscr_sat, or whether we don't really care enough?
Given the comment
/* Which bit we set is completely arbitrary, but clear the rest. */
I don't think VsrD is helpful.
In "target/ppc: Split out VSCR_SAT to a vector field":
ppc_vsr_t vsr[64] QEMU_ALIGNED(16);
+ /* Non-zero if and only if VSCR_SAT should be set. */
+ ppc_vsr_t vscr_sat;
Better to add the QEMU_ALIGNED(16) to vscr_sat as well. Yes, it will already
happen to be aligned by placement, but this is also a bit documentation.
In "target/ppc: convert vadd*s and vsub*s to vector operations":
if (sat) { \
- set_vscr_sat(env); \
+ vscr_sat->u32[0] = 1; \
} \
Changed in error?
r~