[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/6] tests/virtio-blk: change assert on data_
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/6] tests/virtio-blk: change assert on data_size in virtio_blk_request() |
Date: |
Wed, 6 Feb 2019 12:32:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-02-06 12:27, Stefano Garzarella wrote:
> The size of data in the virtio_blk_request must be a multiple
> of 512 bytes for IN and OUT requests, or a multiple of the size
> of struct virtio_blk_discard_write_zeroes for DISCARD and
> WRITE_ZEROES requests.
>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Stefano Garzarella <address@hidden>
> ---
> tests/virtio-blk-test.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c
> index 04c608764b..0739498da7 100644
> --- a/tests/virtio-blk-test.c
> +++ b/tests/virtio-blk-test.c
> @@ -144,7 +144,20 @@ static uint64_t virtio_blk_request(QGuestAllocator
> *alloc, QVirtioDevice *d,
> uint64_t addr;
> uint8_t status = 0xFF;
>
> - g_assert_cmpuint(data_size % 512, ==, 0);
> + switch (req->type) {
> + case VIRTIO_BLK_T_IN:
> + case VIRTIO_BLK_T_OUT:
> + g_assert_cmpuint(data_size % 512, ==, 0);
> + break;
> + case VIRTIO_BLK_T_DISCARD:
> + case VIRTIO_BLK_T_WRITE_ZEROES:
> + g_assert_cmpuint(data_size %
> + sizeof(struct virtio_blk_discard_write_zeroes), ==,
> 0);
> + break;
> + default:
> + g_assert_cmpuint(data_size, ==, 0);
> + }
> +
> addr = guest_alloc(alloc, sizeof(*req) + data_size);
>
> virtio_blk_fix_request(d, req);
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features, Stefano Garzarella, 2019/02/06
- [Qemu-devel] [PATCH v3 1/6] virtio-blk: add acct_failed param to virtio_blk_handle_rw_error(), Stefano Garzarella, 2019/02/06
- [Qemu-devel] [PATCH v3 2/6] virtio-blk: add host_features field in VirtIOBlock, Stefano Garzarella, 2019/02/06
- [Qemu-devel] [PATCH v3 3/6] virtio-blk: add "discard" and "write-zeroes" properties, Stefano Garzarella, 2019/02/06
- [Qemu-devel] [PATCH v3 5/6] tests/virtio-blk: change assert on data_size in virtio_blk_request(), Stefano Garzarella, 2019/02/06
- Re: [Qemu-devel] [PATCH v3 5/6] tests/virtio-blk: change assert on data_size in virtio_blk_request(),
Thomas Huth <=
- [Qemu-devel] [PATCH v3 4/6] virtio-blk: add DISCARD and WRITE_ZEROES features, Stefano Garzarella, 2019/02/06
- [Qemu-devel] [PATCH v3 6/6] tests/virtio-blk: add test for WRITE_ZEROES command, Stefano Garzarella, 2019/02/06
- Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features, no-reply, 2019/02/07
- Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features, Michael S. Tsirkin, 2019/02/07
- Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features, no-reply, 2019/02/07
- Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features, no-reply, 2019/02/07
- Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features, no-reply, 2019/02/07
- Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features, Stefan Hajnoczi, 2019/02/08