[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/3] Linux user for 4.0 patches
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PULL 0/3] Linux user for 4.0 patches |
Date: |
Thu, 7 Feb 2019 14:01:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
I'm going to resend an updated series.
Thanks,
Laurent
On 07/02/2019 12:37, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [Qemu-devel] [PULL 0/3] Linux user for 4.0 patches
> Type: series
> Message-id: address@hidden
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
> t [tag update] patchew/address@hidden -> patchew/address@hidden
> * [new tag] patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> 11efd0b554 linux-user: add new netlink types
> a7c0a6a696 linux-user: Check sscanf return value in open_net_route()
> e1edb0bc04 Fix linux-user crashes in ioctl(SIOCGIFCONF) when ifc_buf is NULL.
>
> === OUTPUT BEGIN ===
> 1/3 Checking commit e1edb0bc04af (Fix linux-user crashes in
> ioctl(SIOCGIFCONF) when ifc_buf is NULL.)
> WARNING: Block comments use a leading /* on a separate line
> #48: FILE: linux-user/syscall.c:4200:
> + /* We can't fit all the extents into the fixed size buffer.
>
> ERROR: "(foo*)" should be "(foo *)"
> #62: FILE: linux-user/syscall.c:4210:
> + host_ifc_buf = (char*)host_ifconf + sizeof(*host_ifconf);
>
> total: 1 errors, 1 warnings, 73 lines checked
>
> Patch 1/3 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> 2/3 Checking commit a7c0a6a696f8 (linux-user: Check sscanf return value in
> open_net_route())
> 3/3 Checking commit 11efd0b55422 (linux-user: add new netlink types)
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> The full log is available at
> http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden
>