[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: fix emulation of accept4/getpeernam
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: fix emulation of accept4/getpeername/getsockname/recvfrom syscalls |
Date: |
Thu, 7 Feb 2019 07:22:37 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH] linux-user: fix emulation of
accept4/getpeername/getsockname/recvfrom syscalls
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
1dca054955..632351e0e1 master -> master
t [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
276d8b2c5d linux-user: fix emulation of
accept4/getpeername/getsockname/recvfrom syscalls
=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#41: FILE: linux-user/syscall.c:2877:
+ if (put_user_u32(ret_addrlen, target_addrlen_addr))
[...]
ERROR: braces {} are necessary for all arms of this statement
#65: FILE: linux-user/syscall.c:2907:
+ if (put_user_u32(ret_addrlen, target_addrlen_addr))
[...]
ERROR: braces {} are necessary for all arms of this statement
#89: FILE: linux-user/syscall.c:2937:
+ if (put_user_u32(ret_addrlen, target_addrlen_addr))
[...]
total: 3 errors, 0 warnings, 98 lines checked
Commit 276d8b2c5d7b (linux-user: fix emulation of
accept4/getpeername/getsockname/recvfrom syscalls) has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden