[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Maintainers, please git-am -m
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] Maintainers, please git-am -m |
Date: |
Fri, 8 Feb 2019 08:45:05 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-02-08 08:30, Markus Armbruster wrote:
> Short story: please add
>
> [am]
> messageid = true
>
> to your .gitconfig.
>
> Long story. git-am can add a Message-id: tag. Looks like this:
>
> commit 335dbb5de1e98c4dc73590349f17bb2a4d72596c
> Author: Thomas Huth <address@hidden>
> Date: Mon Feb 4 09:25:43 2019 +0100
> Commit: Peter Maydell <address@hidden>
> CommitDate: Mon Feb 4 15:25:21 2019 +0000
>
> tests/docker/test-mingw and docs: Remove --with-sdlabi=2.0
>
> Patchew currently reports failures with the mingw docker test - this
> is due to --with-sdlabi=2.0 configure flag which does not exist
> anymore.
> Remove this remainder from the docker test and the docs now.
>
> Signed-off-by: Thomas Huth <address@hidden>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
> Acked-by: Alex Bennée <address@hidden>
> ---> Message-id: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
>
> The Message-id identifies the patch e-mail. It makes finding the review
> thread easier and more reliable. It's also a valid key on Patchew[*].
>
> Sadly, not all of our commits don't carry it. Here's how top committers
> have been doing recently[**]:
>
> with without
> 264 21 Peter Maydell <address@hidden>
> 65 2 Gerd Hoffmann <address@hidden>
> 64 0 Laurent Vivier <address@hidden>
> 64 0 Eric Blake <address@hidden>
> 62 1 Eduardo Habkost <address@hidden>
> 56 0 Markus Armbruster <address@hidden>
> 29 72 Richard Henderson <address@hidden>
> 24 24 Paolo Bonzini <address@hidden>
> 10 31 Marcel Apfelbaum <address@hidden>
> 0 107 Kevin Wolf <address@hidden>
> 0 106 David Gibson <address@hidden>
> 0 93 Michael S. Tsirkin <address@hidden>
> 0 81 Aleksandar Markovic <address@hidden>
> 0 69 Samuel Thibault <address@hidden>
> 0 54 Alex Bennée <address@hidden>
> 0 50 Thomas Huth <address@hidden>
> 0 29 Anthony PERARD <address@hidden>
> 0 28 Marc-André Lureau <address@hidden>
>
> Not bad, but there's room for improvement.
I'd like to, but I can't. I'm still using git 1.8 and the -m parameter
is not supported there yet.
Thomas
- [Qemu-devel] Maintainers, please git-am -m, Markus Armbruster, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m,
Thomas Huth <=
- Re: [Qemu-devel] Maintainers, please git-am -m, Cornelia Huck, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m, Philippe Mathieu-Daudé, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m, Eric Blake, 2019/02/25