Re: [Qemu-devel] [PATCH v3 00/12] target/arm: tcg vector cleanups

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v3 00/12] target/arm: tcg vector cleanups
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
14ab3e4b2d target/arm: Add missing clear_tail calls
6e1ff3edb0 target/arm: Use vector operations for saturation
0e4e921a93 target/arm: Split out FPSCR.QC to a vector field
40b552d504 target/arm: Fix set of bits kept in xregs[ARM_VFP_FPSCR]
3ee1da71e1 target/arm: Split out flags setting from vfp compares
41e8694369 target/arm: Fix arm_cpu_dump_state vs FPSCR
23628c03ad target/arm: Fix vfp_gdb_get/set_reg vs FPSCR
780dc13c0e target/arm: Remove neon min/max helpers
fc636d7cdc target/arm: Use tcg integer min/max primitives for neon
8ff6492f62 target/arm: Use vector minmax expanders for aarch32
d86eaa3793 target/arm: Use vector minmax expanders for aarch64
fc0b82c4ab target/arm: Rely on optimization within tcg_gen_gvec_or

=== OUTPUT BEGIN ===
1/12 Checking commit fc0b82c4ab74 (target/arm: Rely on optimization within 
tcg_gen_gvec_or)
2/12 Checking commit d86eaa379343 (target/arm: Use vector minmax expanders for 
aarch64)
3/12 Checking commit 8ff6492f628b (target/arm: Use vector minmax expanders for 
aarch32)
4/12 Checking commit fc636d7cdc94 (target/arm: Use tcg integer min/max 
primitives for neon)
5/12 Checking commit 780dc13c0ef9 (target/arm: Remove neon min/max helpers)
6/12 Checking commit 23628c03ad1b (target/arm: Fix vfp_gdb_get/set_reg vs FPSCR)
ERROR: trailing statements should be on next line
#22: FILE: target/arm/helper.c:84:
+    case 1: stl_p(buf, vfp_get_fpscr(env)); return 4;

ERROR: trailing statements should be on next line
#31: FILE: target/arm/helper.c:110:
+    case 1: vfp_set_fpscr(env, ldl_p(buf)); return 4;

total: 2 errors, 0 warnings, 16 lines checked

Patch 6/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/12 Checking commit 41e8694369f0 (target/arm: Fix arm_cpu_dump_state vs FPSCR)
8/12 Checking commit 3ee1da71e10e (target/arm: Split out flags setting from vfp 
compares)
9/12 Checking commit 40b552d5049b (target/arm: Fix set of bits kept in 
xregs[ARM_VFP_FPSCR])
10/12 Checking commit 0e4e921a93e3 (target/arm: Split out FPSCR.QC to a vector 
field)
11/12 Checking commit 6e1ff3edb001 (target/arm: Use vector operations for 
saturation)
ERROR: spaces required around that '*' (ctx:WxV)
#357: FILE: target/arm/vec_helper.c:774:
+    TYPEN *d = vd, *n = vn; TYPEM *m = vm;                                 \
                                   ^

total: 1 errors, 0 warnings, 438 lines checked

Patch 11/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/12 Checking commit 14ab3e4b2dd0 (target/arm: Add missing clear_tail calls)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden