Re: [Qemu-devel] [PATCH slirp 0/5] Make it a standalone project

[Marc-André Lureau]

Hi

On Sun, Feb 10, 2019 at 10:42 PM Peter Maydell <address@hidden> wrote:
>
> On Sun, 10 Feb 2019 at 21:38, Samuel Thibault <address@hidden> wrote:
> >
> > Hello,
> >
> > Peter Maydell, le dim. 10 févr. 2019 21:35:37 +0000, a ecrit:
> > > On Fri, 8 Feb 2019 at 20:58, <address@hidden> wrote:
> > > > As discussed earlier in "[PATCH for-3.2 00/41] RFC: slirp: make it
> > > > again a standalone project" and other threads, it would be useful to
> > > > make slirp a separate project (the submodule approach was discarded)
> > > > for various projects to share.
> > >
> > > > The following patches add meson build system (if necessary for older
> > > > distros, autotools could be added - however I believe python & ninja
> > > > are generally available on the QEMU supported platforms)
> > >
> > > Do you really need to make QEMU add an extra build dependency
> > > just to use a different build system?
> >
> > AIUI, this patches series is meant for the slirp repository, not the
> > QEMU repository. I.e. just to show how it'll look like, until a project
> > it settled somewhere and the discussion can happen there.
>
> Yes, but we're going to be pulling it in as a submodule,
> so a split out libslirp in its own repository with extra
> build dependencies is harder to work with than one without.
>

Why do you think it should be a submodule? That's the approach I
proposed first, but Daniel suggested to make it immediately a shared
library if possible.

Regarding the build system, if meson/ninja is problematic for some
distro, we can come up with autotools or plain Make for a while.



-- 
Marc-André Lureau