On 2/11/19 10:13 PM, Stefan Berger wrote:
On 2/11/19 3:09 PM, Liam Merwick wrote:
On 11/02/2019 19:56, Stefan Berger wrote:
On 2/11/19 11:02 AM, Philippe Mathieu-Daudé wrote:
On 2/11/19 4:03 PM, Liam Merwick wrote:
[...]
- printf("tpm_tis: %s length = %d\n", string, len);
+ printf("tpm_tis: %s length = %u\n", string, len);
So here the format is '%zu'.
However in code cleanup we try go get ride of printf() calls and
replace them with trace points.
This code is only used for debugging if DEBUG_TIS has been #defined.
No need to add tracing here.
I'd come up the attached change (but that seems like overkill).
I don't think we need tracing for this.
So if you think the code is mature enough, let's remove the DEBUG calls!
Else we prefer to convert DEBUG printf to trace events because (at least):
- no need to recompile to enable debugging
- when compiled with debugging, you don't mess with STDIO which can be
used as a chardev backend.