Re: [Qemu-devel] [PATCH v2] Add a gitlab-ci file for Continuous Integration testing on Gitlab

[Marc-André Lureau]

Hi

On Wed, Feb 13, 2019 at 12:55 PM Thomas Huth <address@hidden> wrote:
>
> This is very convenient for people like me who store their QEMU git trees
> on gitlab.com: Automatic CI pipelines are now run for each branch that is
> pushed to the server - useful for some extra-testing before sending PULL-
> requests for example. Since the runtime of the jobs is limited to 1h, the
> jobs are distributed into multiple pipelines - this way everything finishs
> fine within time (ca. 30 minutes currently).
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  An example can be seen here: https://gitlab.com/huth/qemu/pipelines/
>
>  I'd really like to get this into the main QEMU repository, so that I don't
>  have to cherry-pick this patch onto my testing branches anymore each time
>  I want to test before sending a PULL request...
>
>  .gitlab-ci.yml | 73 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  MAINTAINERS    |  5 ++++
>  2 files changed, 78 insertions(+)
>  create mode 100644 .gitlab-ci.yml
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> new file mode 100644
> index 0000000..79d02cf
> --- /dev/null
> +++ b/.gitlab-ci.yml
> @@ -0,0 +1,73 @@
> +before_script:
> + - apt-get update -qq
> + - apt-get install -y -qq flex bison libglib2.0-dev libpixman-1-dev 
> genisoimage
> +
> +build-system1:
> + script:
> + - apt-get install -y -qq libgtk-3-dev libvte-dev nettle-dev libcacard-dev
> +      libusb-dev libvde-dev libspice-protocol-dev libgl1-mesa-dev
> + - ./configure --enable-werror --target-list="aarch64-softmmu alpha-softmmu
> +      cris-softmmu hppa-softmmu lm32-softmmu moxie-softmmu 
> microblazeel-softmmu
> +      mips64el-softmmu m68k-softmmu ppc-softmmu riscv64-softmmu 
> sparc-softmmu"
> + - make -j2

Have you tried $(nproc) ?

> + - make -j2 check
> +
> +build-system2:
> + script:
> + - apt-get install -y -qq libsdl2-dev libgcrypt-dev libbrlapi-dev libaio-dev
> +      libfdt-dev liblzo2-dev librdmacm-dev libibverbs-dev libibumad-dev
> + - ./configure --enable-werror --target-list="tricore-softmmu 
> unicore32-softmmu
> +      microblaze-softmmu mips-softmmu riscv32-softmmu s390x-softmmu 
> sh4-softmmu
> +      sparc64-softmmu x86_64-softmmu xtensa-softmmu nios2-softmmu 
> or1k-softmmu"
> + - make -j2
> + - make -j2 check
> +
> +build-disabled:
> + script:
> + - ./configure --enable-werror --disable-rdma --disable-slirp --disable-curl
> +      --disable-capstone --disable-live-block-migration --disable-glusterfs
> +      --disable-replication --disable-coroutine-pool --disable-smartcard
> +      --disable-guest-agent --disable-curses --disable-libxml2 --disable-tpm
> +      --disable-qom-cast-debug --disable-spice --disable-vhost-vsock
> +      --disable-vhost-net --disable-vhost-crypto --disable-vhost-user
> +      --target-list="i386-softmmu ppc64-softmmu mips64-softmmu 
> i386-linux-user"
> + - make -j2
> + - make -j2 check-qtest SPEED=slow
> +
> +build-tcg-disabled:
> + script:
> + - apt-get install -y -qq clang libgtk-3-dev libbluetooth-dev libusb-dev
> + - ./configure --cc=clang --enable-werror --disable-tcg --audio-drv-list=""
> + - make -j2
> + - make check-unit
> + - make check-qapi-schema
> + - cd tests/qemu-iotests/
> + - ./check -raw 001 002 003 004 005 008 009 010 011 012 021 025 032 033 048
> +            052 063 077 086 101 104 106 113 147 148 150 151 152 157 159 160
> +            163 170 171 183 184 192 194 197 205 208 215 221 222 226 227 236
> + - ./check -qcow2 001 002 003 004 005 007 008 009 010 011 012 013 017 018 019
> +            020 021 022 024 025 027 028 029 031 032 033 034 035 036 037 038
> +            039 040 042 043 046 047 048 049 050 051 052 053 054 056 057 058
> +            060 061 062 063 065 066 067 068 069 071 072 073 074 079 080 082
> +            085 086 089 090 091 095 096 097 098 099 102 103 104 105 107 108
> +            110 111 114 117 120 122 124 126 127 129 130 132 133 134 137 138
> +            139 140 141 142 143 144 145 147 150 151 152 154 155 156 157 158
> +            161 165 170 172 174 176 177 179 184 186 187 190 192 194 195 196
> +            197 200 202 203 205 208 209 214 215 216 217 218 222 226 227 229 
> 234
> +
> +build-user:
> + script:
> + - ./configure --enable-werror --disable-system --disable-guest-agent
> +               --disable-capstone --disable-slirp --disable-fdt
> + - make -j2
> + - make run-tcg-tests-i386-linux-user run-tcg-tests-x86_64-linux-user
> +
> +build-clang:
> + script:
> + - apt-get install -y -qq clang libsdl2-dev
> +      xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev 
> librbd-dev
> + - ./configure --cc=clang --cxx=clang++ --enable-werror
> +      --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
> +                     ppc-softmmu s390x-softmmu x86_64-softmmu arm-linux-user"
> + - make -j2
> + - make -j2 check
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a2da141..191138c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2484,6 +2484,11 @@ S: Maintained
>  F: .cirrus.yml
>  W: https://cirrus-ci.com/github/qemu/qemu
>
> +GitLab Continuous Integration
> +M: Thomas Huth <address@hidden>
> +S: Maintained
> +F: .gitlab-ci.yml
> +
>  Guest Test Compilation Support
>  M: Alex Bennée <address@hidden>
>  R: Philippe Mathieu-Daudé <address@hidden>
> --
> 1.8.3.1
>
>

Despite the duplication of CI files, which is not really a problem imho,

lgtm,
Reviewed-by: Marc-André Lureau <address@hidden>



-- 
Marc-André Lureau