[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argu
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument |
Date: |
Wed, 13 Feb 2019 09:40:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/13/19 6:40 AM, Philippe Mathieu-Daudé wrote:
> On 2/13/19 7:53 AM, Yuval Shaia wrote:
>> The function argument rdma_dev_res is not needed as it is stored in the
>> backend_dev object at init.
>>
>> Signed-off-by: Yuval Shaia <address@hidden>
>> Reviewed-by: Marcel Apfelbaum<address@hidden>
>
> Should we teach checkpatch.pl to check name/space/email?
I already have a proposed patch to teach it to recognize typos such as
'Reveiwed-by:'; it would be easy to expand that to also force
'name/space/email'.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 8/9] hw/pvrdma: Delete pvrdma_exit function, (continued)
- [Qemu-devel] [PATCH v2 8/9] hw/pvrdma: Delete pvrdma_exit function, Yuval Shaia, 2019/02/13
- [Qemu-devel] [PATCH v2 6/9] hw/rdma: Free all receive buffers when QP is destroyed, Yuval Shaia, 2019/02/13
- [Qemu-devel] [PATCH v2 3/9] hw/rdma: Protect against concurrent execution of poll_cq, Yuval Shaia, 2019/02/13
- [Qemu-devel] [PATCH v2 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface, Yuval Shaia, 2019/02/13
- [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument, Yuval Shaia, 2019/02/13
- [Qemu-devel] [PATCH v1 2/9] hw/rdma: Introduce locked qlist, Yuval Shaia, 2019/02/13
- [Qemu-devel] [PATCH v2 2/9] hw/rdma: Introduce protected qlist, Yuval Shaia, 2019/02/13
- [Qemu-devel] [PATCH v2 1/9] hw/rdma: Switch to generic error reporting way, Yuval Shaia, 2019/02/13
- Re: [Qemu-devel] [PATCH v2 0/9] Misc fixes to pvrdma device, Marcel Apfelbaum, 2019/02/14