Re: [Qemu-devel] [PATCH v3 2/2] hostmem-file: reject invalid pmem file sizes

[Stefan Hajnoczi]

On Thu, Feb 14, 2019 at 12:19:15PM +0800, Wei Yang wrote:
> On Thu, Feb 14, 2019 at 11:10:04AM +0800, Stefan Hajnoczi wrote:
> >diff --git a/util/oslib-win32.c b/util/oslib-win32.c
> >index b4c17f5dfa..bd633afab6 100644
> >--- a/util/oslib-win32.c
> >+++ b/util/oslib-win32.c
> >@@ -560,6 +560,11 @@ void os_mem_prealloc(int fd, char *area, size_t memory, 
> >int smp_cpus,
> >     }
> > }
> > 
> >+uint64_t qemu_get_pmem_size(const char *filename, Error **errp)
> >+{
> >+    error_setg(errp, "pmem support not available");
> >+    return 0;
> >+}
> 
> After the cleanup from Igor, qemu_get_pmem_size() would be invoked only on
> POSIX system.
> 
> Is it still necessary to define this on win32?

Either way is possible.  I'd like to leave it like this unless there are
strong feelings against this.

Stefan

signature.asc
Description: PGP signature