Re: [Qemu-devel] [PATCH v3 0/9] target/mips: Add MSA ASE tests

[Aleksandar Rikalo]

> From: Aleksandar Markovic <address@hidden>
> Sent: Thursday, February 14, 2019 12:18 PM
> To: address@hidden
> Cc: address@hidden; Aleksandar Markovic; Aleksandar Rikalo; address@hidden
> Subject: [PATCH v3 0/9] target/mips: Add MSA ASE tests
>
> From: Aleksandar Markovic <address@hidden>
>
> v2->v3:
>
>   - minor cosmetic changes
>   - added wrappers and tests for MSA logic instructions
>
> v1->v2:
>
>   - added refference to the original commit in patch #1
>   - corrected copy-and-paste error in comments in 12 new source files
>   - renamed "bit_counting" subdirectory to "bit-counting"
>   - added wrappers and tests for MSA interleave instructions
>
> This series begins to add unit tests (aka tcg tests) for MIPS'
> MSA ASE. More tests and related test infrastructure will be added
> in subsequent version of this series.
>
> There are several checkpatch warnings that are all false positives
> for given circumstances.
>
> Aleksandar Markovic (9):
>   tests/tcg: target/mips: Remove an unnecessary file
>   tests/tcg: target/mips: Add a header with test inputs
>   tests/tcg: target/mips: Add a header with test utilities
>   tests/tcg: target/mips: Add wrappers for MSA bit counting instructions
>   tests/tcg: target/mips: Add tests for MSA bit counting instructions
>   tests/tcg: target/mips: Add wrappers for MSA interleave instructions
>   tests/tcg: target/mips: Add tests for MSA interleave instructions
>   tests/tcg: target/mips: Add wrappers for MSA logic instructions
>   tests/tcg: target/mips: Add tests for MSA logic instructions
>
>  tests/tcg/mips/include/test_inputs.h               | 122 ++++++++++++++++
>  tests/tcg/mips/include/test_utils.h                |  84 +++++++++++
>  tests/tcg/mips/include/wrappers_msa.h              | 101 ++++++++++++++
>  tests/tcg/mips/mips64-dspr2/.directory             |   2 -
>  .../user/ase/msa/bit-counting/test_msa_nloc_b.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_nloc_d.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_nloc_h.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_nloc_w.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_nlzc_b.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_nlzc_d.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_nlzc_h.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_nlzc_w.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_pcnt_b.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_pcnt_d.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_pcnt_h.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/bit-counting/test_msa_pcnt_w.c    | 144 +++++++++++++++++++
>  .../user/ase/msa/interleave/test_msa_ilvev_b.c     | 153 
> +++++++++++++++++++++
>  .../user/ase/msa/interleave/test_msa_ilvev_d.c     | 153 
> +++++++++++++++++++++
>  .../user/ase/msa/interleave/test_msa_ilvev_h.c     | 153 
> +++++++++++++++++++++
>  .../user/ase/msa/interleave/test_msa_ilvev_w.c     | 153 
> +++++++++++++++++++++
>  .../mips/user/ase/msa/interleave/test_msa_ilvl_b.c | 153 
> +++++++++++++++++++++
>  .../mips/user/ase/msa/interleave/test_msa_ilvl_d.c | 153 
> +++++++++++++++++++++
>  .../mips/user/ase/msa/interleave/test_msa_ilvl_h.c | 153 
> +++++++++++++++++++++
>  .../mips/user/ase/msa/interleave/test_msa_ilvl_w.c | 153 
> +++++++++++++++++++++
>  .../user/ase/msa/interleave/test_msa_ilvod_b.c     | 153 
> +++++++++++++++++++++
>  .../user/ase/msa/interleave/test_msa_ilvod_d.c     | 153 
> +++++++++++++++++++++
>  .../user/ase/msa/interleave/test_msa_ilvod_h.c     | 153 
> +++++++++++++++++++++
>  .../user/ase/msa/interleave/test_msa_ilvod_w.c     | 153 
> +++++++++++++++++++++
>  .../mips/user/ase/msa/interleave/test_msa_ilvr_b.c | 153 
> +++++++++++++++++++++
>  .../mips/user/ase/msa/interleave/test_msa_ilvr_d.c | 153 
> +++++++++++++++++++++
>  .../mips/user/ase/msa/interleave/test_msa_ilvr_h.c | 153 
> +++++++++++++++++++++
>  .../mips/user/ase/msa/interleave/test_msa_ilvr_w.c | 153 
> +++++++++++++++++++++
>  tests/tcg/mips/user/ase/msa/logic/test_msa_and_v.c | 153 
> +++++++++++++++++++++
>  tests/tcg/mips/user/ase/msa/logic/test_msa_nor_v.c | 153 
> +++++++++++++++++++++
>  tests/tcg/mips/user/ase/msa/logic/test_msa_or_v.c  | 153 
> +++++++++++++++++++++
>  tests/tcg/mips/user/ase/msa/logic/test_msa_xor_v.c | 153 
> +++++++++++++++++++++
>  36 files changed, 5095 insertions(+), 2 deletions(-)
>  create mode 100644 tests/tcg/mips/include/test_inputs.h
>  create mode 100644 tests/tcg/mips/include/test_utils.h
>  create mode 100644 tests/tcg/mips/include/wrappers_msa.h
>  delete mode 100644 tests/tcg/mips/mips64-dspr2/.directory
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvev_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvev_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvev_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvev_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvl_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvl_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvl_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvl_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvod_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvod_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvod_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvod_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvr_b.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvr_d.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvr_h.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvr_w.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/logic/test_msa_and_v.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/logic/test_msa_nor_v.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/logic/test_msa_or_v.c
>  create mode 100644 tests/tcg/mips/user/ase/msa/logic/test_msa_xor_v.c
>
> --
> 2.7.4

For all patches in this series:

Reviewed-by: Aleksandar Rikalo <address@hidden>