[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] dataplane/xen-block: remove dead code
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] dataplane/xen-block: remove dead code |
Date: |
Fri, 15 Feb 2019 21:38:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/15/19 5:25 PM, Paul Durrant wrote:
> The if() statement is clearly bogus (dead code which should have been
> cleaned up when grant mapping was removed).
"... was removed in 06454c24ad)."
>
> Spotted by Coverity: CID 1398635
>
> While in the neighbourhood, add a missing 'fall through' annotation.
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Paul Durrant <address@hidden>
> ---
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Stefano Stabellini <address@hidden>
> Cc: Anthony Perard <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> ---
> hw/block/dataplane/xen-block.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c
> index c6a15da024..f1523c5b45 100644
> --- a/hw/block/dataplane/xen-block.c
> +++ b/hw/block/dataplane/xen-block.c
> @@ -281,10 +281,6 @@ static void xen_block_complete_aio(void *opaque, int ret)
> break;
> case BLKIF_OP_WRITE:
> case BLKIF_OP_FLUSH_DISKCACHE:
> - if (!request->req.nr_segments) {
> - break;
> - }
> - break;
> default:
> break;
> }
> @@ -298,6 +294,7 @@ static void xen_block_complete_aio(void *opaque, int ret)
> if (!request->req.nr_segments) {
> break;
> }
> + /* fall through */
> case BLKIF_OP_READ:
> if (request->status == BLKIF_RSP_OKAY) {
> block_acct_done(blk_get_stats(dataplane->blk), &request->acct);
>