[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] xics: Drop the KVM ICP class
|
From: |
David Gibson |
|
Subject: |
Re: [Qemu-devel] [PATCH 05/10] xics: Drop the KVM ICP class |
|
Date: |
Mon, 18 Feb 2019 10:37:11 +1100 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Feb 15, 2019 at 02:35:03PM +0100, Cédric Le Goater wrote:
> On 2/15/19 2:18 PM, Greg Kurz wrote:
> > On Fri, 15 Feb 2019 13:55:53 +0100
> > Cédric Le Goater <address@hidden> wrote:
> >
> >> On 2/15/19 12:40 PM, Greg Kurz wrote:
> >>> The KVM ICP class isn't used anymore. Drop it.
> >>
> >> Isn't migration complaining ? If not,
> >>
> >
> > Hm.. no, but why would migration complain ?
>
> You are changing the type name of the object being transferred:
>
> "icp-kcm" -> "icp"
It's a little more complex than that. The way migration works, the
state associated with the base class is transferred under the name
"icp" and the state associated with the derived class is transferred
under the name "icp-kvm".
> Isn't that an issue ?
It would be.. except that there is no extra state in the derived
class, which is why we got away with this not-very-good solution at
all in the first place.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH 02/10] xics: Handle KVM ICP reset from the common code, (continued)
[Qemu-devel] [PATCH 06/10] xics: Explicitely call KVM ICS methods from the common code, Greg Kurz, 2019/02/15
[Qemu-devel] [PATCH 07/10] xics: Handle KVM ICS reset from the "simple" ICS code, Greg Kurz, 2019/02/15
[Qemu-devel] [PATCH 10/10] xics: Drop the KVM ICS class, Greg Kurz, 2019/02/15
[Qemu-devel] [PATCH 09/10] spapr/irq: Use the "simple" ICS class for KVM, Greg Kurz, 2019/02/15