Re: [Qemu-devel] [PATCH 1/1] Introduce a Python module structure

[Caio Carrara]

On Wed, Feb 06, 2019 at 11:29:01AM -0500, Cleber Rosa wrote:
> This is a simple move of Python code that wraps common QEMU
> functionality, and are used by a number of different tests
> and scripts.
> 
> By treating that code as a real Python module, we can more easily:
>  * reuse code
>  * have a proper place for the module's own unittests
>  * apply a more consistent style
>  * generate documentation
> 
> Signed-off-by: Cleber Rosa <address@hidden>

Reviewed-by: Caio Carrara <address@hidden>

> ---
>  configure                                  |  1 +
>  scripts/qemu.py => python/qemu/__init__.py | 11 ++++++-----
>  {scripts/qmp => python/qemu}/qmp.py        |  0
>  {scripts => python/qemu}/qtest.py          |  5 +++--
>  scripts/device-crash-test                  |  2 ++
>  scripts/qmp/__init__.py                    |  0
>  scripts/qmp/qemu-ga-client                 |  5 ++++-
>  scripts/qmp/qmp-shell                      |  4 +++-
>  scripts/render_block_graph.py              |  2 ++
>  tests/acceptance/avocado_qemu/__init__.py  |  5 ++---
>  tests/acceptance/virtio_version.py         |  2 +-
>  tests/migration/guestperf/engine.py        |  7 ++++---
>  tests/qemu-iotests/235                     |  2 +-
>  tests/qemu-iotests/238                     |  2 +-
>  tests/qemu-iotests/iotests.py              |  4 ++--
>  tests/vm/basevm.py                         |  2 +-
>  16 files changed, 33 insertions(+), 21 deletions(-)
>  rename scripts/qemu.py => python/qemu/__init__.py (98%)
>  rename {scripts/qmp => python/qemu}/qmp.py (100%)
>  rename {scripts => python/qemu}/qtest.py (98%)
>  delete mode 100644 scripts/qmp/__init__.py
> 
{...}
> 

Thanks,
-- 
Caio Carrara
Software Engineer, Virt Team - Red Hat
address@hidden