Re: [Qemu-devel] [PATCH v3 11/11] display: add -display spice-app launching a Spice client

[Marc-André Lureau]

Hi

On Thu, Feb 21, 2019 at 4:19 PM Gerd Hoffmann <address@hidden> wrote:
>
>   Hi,
>
> > > Too bad.  So broken for pretty much everyone I guess?
> >
> > It should be easy to backport the patch for older virt-viewer.
> >
> > But to get the "complete" experience, I would recommend you use the
> > upcoming virt-viewer. Without it, you won't have the QMP monitor
> > handling, VTE serial console, etc..
> >
> > > I think we should have a fallback which exec's remote-viewer then, for
> > > the next 2-3 years, until a fixed virt-viewer is in widespread use ...
> >
> > I am not sure, I think it make sense to require the upcoming
> > virt-viewer instead.
> >
> > After all, if you use a bleeding edge qemu, you can use bleeding edge
> > virt-viewer, no?
>
> Fair enough, but please add a hint to the error message then so users
> have a clue how to deal with it.
>

Would something like that be helpful?

diff --git a/ui/spice-app.c b/ui/spice-app.c
index 4f5229f3ee..69f92e440c 100644
--- a/ui/spice-app.c
+++ b/ui/spice-app.c
@@ -181,6 +181,7 @@ static void spice_app_display_init(DisplayState
*ds, DisplayOptions *opts)
     g_app_info_launch_default_for_uri(uri, NULL, &err);
     if (err) {
         error_report("Failed to launch %s URI: %s", uri, err->message);
+        error_report("You need a capable Spice client, such as
virt-viewer 8.0");
         exit(1);
     }
     g_free(uri);

-- 
Marc-André Lureau