[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/21] hw/arm/armsse: Fix memory leak in error-exit p
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 01/21] hw/arm/armsse: Fix memory leak in error-exit path |
Date: |
Thu, 21 Feb 2019 18:57:19 +0000 |
Coverity points out (CID 1398632, CID 1398650) that we
leak a couple of allocated strings in the error-exit
code path for setting up the MHUs in the ARMSSE.
Fix this bug by moving the allocate-and-free of each
string to be closer to the use, so we do the free before
doing the error-exit check.
Fixes: f8574705f62b38a ("hw/arm/armsse: Add unimplemented-device stubs for
MHUs")
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
---
hw/arm/armsse.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/arm/armsse.c b/hw/arm/armsse.c
index 9a8c49547db..d0207dbabc7 100644
--- a/hw/arm/armsse.c
+++ b/hw/arm/armsse.c
@@ -762,26 +762,28 @@ static void armsse_realize(DeviceState *dev, Error **errp)
if (info->has_mhus) {
for (i = 0; i < ARRAY_SIZE(s->mhu); i++) {
- char *name = g_strdup_printf("MHU%d", i);
- char *port = g_strdup_printf("port[%d]", i + 3);
+ char *name;
+ char *port;
+ name = g_strdup_printf("MHU%d", i);
qdev_prop_set_string(DEVICE(&s->mhu[i]), "name", name);
qdev_prop_set_uint64(DEVICE(&s->mhu[i]), "size", 0x1000);
object_property_set_bool(OBJECT(&s->mhu[i]), true,
"realized", &err);
+ g_free(name);
if (err) {
error_propagate(errp, err);
return;
}
+ port = g_strdup_printf("port[%d]", i + 3);
mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->mhu[i]), 0);
object_property_set_link(OBJECT(&s->apb_ppc0), OBJECT(mr),
port, &err);
+ g_free(port);
if (err) {
error_propagate(errp, err);
return;
}
- g_free(name);
- g_free(port);
}
}
--
2.20.1
- [Qemu-devel] [PULL 00/21] target-arm queue, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 02/21] target/arm: v8M MPU should use background region as default, not always, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 01/21] hw/arm/armsse: Fix memory leak in error-exit path,
Peter Maydell <=
- [Qemu-devel] [PULL 04/21] target/arm: Restructure disas_fp_int_conv, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 10/21] hw/timer/pl031: Convert to using trace events, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 03/21] target/arm: Stop unintentional sign extension in pmu_init, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 13/21] hw/char/pl011: Use '0x' prefix when logging hex numbers, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 09/21] hw/timer/pl031: Allow use as an embedded-struct device, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 11/21] hw/char/pl011: Allow use as an embedded-struct device, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 14/21] hw/arm/armsse: Document SRAM_ADDR_WIDTH property in header comment, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 12/21] hw/char/pl011: Support all interrupt lines, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 07/21] target/arm: Implement ARMv8.3-JSConv, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 06/21] target/arm: Rearrange Floating-point data-processing (2 regs), Peter Maydell, 2019/02/21