[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/5] virtio-gpu: remove useless 'waiting' field
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 4/5] virtio-gpu: remove useless 'waiting' field |
Date: |
Fri, 22 Feb 2019 09:24:35 +0100 |
From: Marc-André Lureau <address@hidden>
Let's check renderer_blocked instead directly.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Christophe Fergeau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
include/hw/virtio/virtio-gpu.h | 1 -
hw/display/virtio-gpu.c | 4 +---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index f8cd8ee96fb2..26a669826688 100644
--- a/include/hw/virtio/virtio-gpu.h
+++ b/include/hw/virtio/virtio-gpu.h
@@ -81,7 +81,6 @@ struct virtio_gpu_ctrl_command {
VirtQueue *vq;
struct virtio_gpu_ctrl_hdr cmd_hdr;
uint32_t error;
- bool waiting;
bool finished;
QTAILQ_ENTRY(virtio_gpu_ctrl_command) next;
};
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 7ada4b83ac29..0baa9ac0ad0e 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -889,8 +889,7 @@ void virtio_gpu_process_cmdq(VirtIOGPU *g)
while (!QTAILQ_EMPTY(&g->cmdq)) {
cmd = QTAILQ_FIRST(&g->cmdq);
- cmd->waiting = g->renderer_blocked;
- if (cmd->waiting) {
+ if (g->renderer_blocked) {
break;
}
@@ -939,7 +938,6 @@ static void virtio_gpu_handle_ctrl(VirtIODevice *vdev,
VirtQueue *vq)
cmd->vq = vq;
cmd->error = 0;
cmd->finished = false;
- cmd->waiting = false;
QTAILQ_INSERT_TAIL(&g->cmdq, cmd, next);
cmd = virtqueue_pop(vq, sizeof(struct virtio_gpu_ctrl_command));
}
--
2.9.3
- [Qemu-devel] [PULL 0/5] Vga 20190222 patches, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 1/5] virtio-gpu: remove unused qdev, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 5/5] display/virtio: add edid support., Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 4/5] virtio-gpu: remove useless 'waiting' field,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 3/5] virtio-gpu: block both 2d and 3d rendering, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 2/5] virtio-gpu: remove unused config_size, Gerd Hoffmann, 2019/02/22
- Re: [Qemu-devel] [PULL 0/5] Vga 20190222 patches, Peter Maydell, 2019/02/25