Re: [Qemu-devel] [PATCH v2 3/6] target/mips: Add emulation of MMI instruction PCPYLD

[Richard Henderson]

On 2/26/19 4:23 AM, Mateja Marjanovic wrote:
> +        if (rs == 0) {
> +            tcg_gen_movi_i64(cpu_mmr[rd], 0);
> +        } else {
> +            tcg_gen_mov_i64(cpu_mmr[rd], cpu_gpr[rs]);
> +        }

Why are you not using gen_load_gpr?

> +        if (rt == 0) {
> +            tcg_gen_movi_i64(cpu_gpr[rd], 0);
> +        } else {
> +            if (rd != rt) {
> +                tcg_gen_mov_i64(cpu_gpr[rd], cpu_gpr[rt]);

Why are you duplicating a check that tcg_gen_mov_i64 will do?


r~