Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 11/11] pflash: Clean up after commit 368a354f02b part 2

[Markus Armbruster]

BALATON Zoltan <address@hidden> writes:

> On Tue, 26 Feb 2019, Markus Armbruster wrote:
>> QOMification left parameter @size unused in pflash_cfi01_register()
>> and pflash_cfi02_register().  Obviously, @size should match
>> @sector_len and @nb_blocs, i.e. size == sector_len * nb_blocs.  All
>> callers satisfy this.
>>
>> Remove @nb_blocs and compute it from @size and @sector_len.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Laszlo Ersek <address@hidden>
>> Reviewed-by: Alex Bennée <address@hidden>
>> ---
[...]
>> diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c
>> index 304dbeab2f..2e526218f4 100644
>> --- a/hw/arm/gumstix.c
>> +++ b/hw/arm/gumstix.c
>> @@ -74,7 +74,7 @@ static void connex_init(MachineState *machine)
>> #endif
>>     if (!pflash_cfi01_register(0x00000000, "connext.rom", connex_rom,
>>                                dinfo ? blk_by_legacy_dinfo(dinfo) : NULL,
>> -                               sector_len, connex_rom / sector_len,
>> +                               sector_len,
>>                                2, 0, 0, 0, 0, be)) {
>
> I'd say you could also reformat and join next line during this change
> to avoid short lines in the middle (also for all other similar changes
> below). But I have no strong feelings about that so I don't
> mind. (This might be easier to review the patch this way but the
> resulting code will look ugly.)

Will do, thanks!