Re: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
72df75a777 target/riscv: Remaining rvc insn reuse 32 bit translators
ac327c0ac9 target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
4ebe14c582 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
812966d438 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
06e544919e target/riscv: Convert @cs_2 insns to share translation functions
b7013da7f9 target/riscv: Remove decode_RV32_64G()
02f42d7145 target/riscv: Remove gen_system()
4e60e91dc7 target/riscv: Rename trans_arith to gen_arith
e991dfaa7d target/riscv: Remove manual decoding of RV32/64M insn
fb0e577549 target/riscv: Remove shift and slt insn manual decoding
9a495cf36e target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
bde9c95401 target/riscv: Move gen_arith_imm() decoding into trans_* functions
60c0bc9616 target/riscv: Remove manual decoding from gen_store()
25cab6f652 target/riscv: Remove manual decoding from gen_load()
e9840d0cbe target/riscv: Remove manual decoding from gen_branch()
4840e9f2d5 target/riscv: Remove gen_jalr()
230f7f47c0 target/riscv: Convert quadrant 2 of RVXC insns to decodetree
e60c8ac1e1 target/riscv: Convert quadrant 1 of RVXC insns to decodetree
590998de94 target/riscv: Convert quadrant 0 of RVXC insns to decodetree
b7f573400e target/riscv: Convert RV priv insns to decodetree
5ca82670a8 target/riscv: Convert RV64D insns to decodetree
dc294c4664 target/riscv: Convert RV32D insns to decodetree
e33c931799 target/riscv: Convert RV64F insns to decodetree
d8458e4eaf target/riscv: Convert RV32F insns to decodetree
e28bad669b target/riscv: Convert RV64A insns to decodetree
83facf8e66 target/riscv: Convert RV32A insns to decodetree
d62f8d335c target/riscv: Convert RVXM insns to decodetree
5164f378e0 target/riscv: Convert RVXI csr insns to decodetree
3f206cb1cb target/riscv: Convert RVXI fence insns to decodetree
ce53d87477 target/riscv: Convert RVXI arithmetic insns to decodetree
be8a4c67e2 target/riscv: Convert RV64I load/store insns to decodetree
cdbbb37a2d target/riscv: Convert RV32I load/store insns to decodetree
9e489f4ff8 target/riscv: Convert RVXI branch insns to decodetree
138a68c761 target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit 138a68c761b7 (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit 9e489f4ff813 (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit cdbbb37a2d98 (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit be8a4c67e295 (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit ce53d87477a9 (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit 3f206cb1cb69 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit 5164f378e0e3 (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit d62f8d335c9e (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit 83facf8e66d6 (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit e28bad669bc1 (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit d8458e4eafb7 (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit e33c9317996c (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit dc294c4664df (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit 5ca82670a81f (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit b7f573400e74 (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit 590998de94e5 (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit e60c8ac1e1eb (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit 230f7f47c0b5 (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit 4840e9f2d590 (target/riscv: Remove gen_jalr())
20/34 Checking commit e9840d0cbe1d (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit 25cab6f65212 (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit 60c0bc9616a6 (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit bde9c95401d9 (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit 9a495cf36e7e (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit fb0e57754972 (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit e991dfaa7db9 (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit 4e60e91dc72a (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit 02f42d7145a5 (target/riscv: Remove gen_system())
29/34 Checking commit b7013da7f93c (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit 06e544919e67 (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit 812966d438a7 (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit 4ebe14c58219 (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit ac327c0ac92e (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit 72df75a7770a (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden