[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees |
Date: |
Thu, 28 Feb 2019 08:01:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 28/02/2019 06.00, David Gibson wrote:
> On Thu, Feb 28, 2019 at 03:35:03PM +1100, Alexey Kardashevskiy wrote:
>> The configure script checks multiple times whether it works in a git
>> repository and it does this by "test -e "${source_path}/.git" in 4 cases
>> but in one case where it tries to enable werror "-d" is used there which
>> fails on git worktrees as .git is a file then and not a directory.
That confused me. What is a "git worktree" where .git is a file? So far
.git was always a directory here...?
Thomas
>> This changes the test to "-e" as other occurrences.
>>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>
> CCing a few likely candidates based on get_maintainer -f
>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 05d72f1..f481ff9 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1835,7 +1835,7 @@ fi
>> # Consult white-list to determine whether to enable werror
>> # by default. Only enable by default for git builds
>> if test -z "$werror" ; then
>> - if test -d "$source_path/.git" && \
>> + if test -e "$source_path/.git" && \
>> { test "$linux" = "yes" || test "$mingw32" = "yes"; }; then
>> werror="yes"
>> else
>
signature.asc
Description: OpenPGP digital signature