[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] crypto/block: Fix build with gcc 9
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH] crypto/block: Fix build with gcc 9 |
Date: |
Thu, 28 Feb 2019 18:06:29 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Feb 28, 2019 at 04:06:06PM +0100, Greg Kurz wrote:
> Build fails with gcc 9:
>
> crypto/block-luks.c:689:18: error: taking address of packed member of ‘struct
> QCryptoBlockLUKSHeader’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
> 689 | be32_to_cpus(&luks->header.payload_offset);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> crypto/block-luks.c:690:18: error: taking address of packed member of ‘struct
> QCryptoBlockLUKSHeader’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
> 690 | be32_to_cpus(&luks->header.key_bytes);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> crypto/block-luks.c:691:18: error: taking address of packed member of ‘struct
> QCryptoBlockLUKSHeader’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
> 691 | be32_to_cpus(&luks->header.master_key_iterations);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> ... a bunch of similar errors...
>
> crypto/block-luks.c:1288:22: error: taking address of packed member of
> ‘struct QCryptoBlockLUKSKeySlot’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
> 1288 | be32_to_cpus(&luks->header.key_slots[i].stripes);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> All members of the QCryptoBlockLUKSKeySlot and QCryptoBlockLUKSHeader are
> naturally aligned and we already check at build time there isn't any
> unwanted padding. Drop the QEMU_PACKED attribute.
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> crypto/block-luks.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
I'll queue this one.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|