[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] isa: Add APM and ACPI dependencies for VT82C686
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] isa: Add APM and ACPI dependencies for VT82C686 |
|
Date: |
Mon, 11 Mar 2019 15:54:04 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/9/19 5:48 PM, BALATON Zoltan wrote:
> Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add
> dependency on these in Kconfig to fix this.
>
> Signed-off-by: BALATON Zoltan <address@hidden>
> ---
> hw/isa/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 57e09a0cb8..e092da3fc3 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -36,6 +36,8 @@ config VT82C686
> select ACPI_SMBUS
> select SERIAL_ISA
> select FDC
> + select APM
Correct, I missed this one.
> + select ACPI_X86
NACK it does require ACPI but not X86.
ACPI_X86 is messy. I tried to fix VT82C686 in my "Kconfig MIPS" series,
but I might have to include this in my 'Kconfig PIIX' series.
>
> config SMC37C669
> bool
>