[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule |
Date: |
Mon, 1 Jun 2020 09:26:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/1/20 4:13 AM, Richard Henderson wrote:
> On 5/22/20 9:37 AM, Philippe Mathieu-Daudé wrote:
>> + $(if $(call startwith,risc,$1),risc,\
>
> Should be "riscv" not "risc". Especially the substitution.
Indeed.
>
>> + $(if $(call startwith,aarch64,$1),arm,\
>> + $(if $(call startwith,x86_64,$1),i386,\
>
> We don't have an exact equality function?
There is this one which returns y/n:
# String testing functions: inputs to these can be any string;
# the output is always either "y" or "n". Leading and trailing whitespace
# is ignored when comparing strings.
# String equality
eq = $(if $(subst $2,,$1)$(subst $1,,$2),n,y)
I'll add a simpler strequal().
- Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule,
Philippe Mathieu-Daudé <=