[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] configure: Don't warn about lack of PIE on macOS
From: |
Cameron Esfahani |
Subject: |
Re: [PATCH] configure: Don't warn about lack of PIE on macOS |
Date: |
Wed, 03 Jun 2020 18:24:58 -0700 |
Reviewed-by: Cameron Esfahani <dirty@apple.com>
Cameron Esfahani
dirty@apple.com
"It is the spirit and not the form of law that keeps justice alive."
Earl Warren
> On Jun 1, 2020, at 5:42 AM, Roman Bolshakov <r.bolshakov@yadro.com> wrote:
>
> ld64 is making PIE executables for 10.7 and above by default, as
> documented in ld(1).
>
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
> configure | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configure b/configure
> index af2ba83f0e..6dddbca4b2 100755
> --- a/configure
> +++ b/configure
> @@ -2137,6 +2137,8 @@ elif compile_prog "-Werror -fPIE -DPIE" "-pie"; then
> QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"
> QEMU_LDFLAGS="-pie $QEMU_LDFLAGS"
> pie="yes"
> +elif test "$darwin" = "yes"; then
> + pie="yes"
> elif test "$pie" = "yes"; then
> error_exit "PIE not available due to missing toolchain support"
> else
> --
> 2.26.1
>
>