[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 26/35] hw/openrisc/cputimer: Emit warning when old code i
From: |
Paolo Bonzini |
Subject: |
Re: [RFC PATCH 26/35] hw/openrisc/cputimer: Emit warning when old code is used |
Date: |
Tue, 9 Jun 2020 13:13:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/openrisc/cputimer.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c
> index 93268815d8..60f2c9667f 100644
> --- a/hw/openrisc/cputimer.c
> +++ b/hw/openrisc/cputimer.c
> @@ -22,6 +22,7 @@
> #include "cpu.h"
> #include "migration/vmstate.h"
> #include "qemu/timer.h"
> +#include "hw/qdev-deprecated.h"
>
> #define TIMER_PERIOD 50 /* 50 ns period for 20 MHz timer */
>
> @@ -135,6 +136,8 @@ static const VMStateDescription vmstate_or1k_timer = {
>
> void cpu_openrisc_clock_init(OpenRISCCPU *cpu)
> {
> + qdev_warn_deprecated_function_used();
> +
> cpu->env.timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, &openrisc_timer_cb,
> cpu);
> cpu->env.ttmr = 0x00000000;
>
>
I was about to give this a pass, but if we did so it should be the CPU
itself that calls cpu_openrisc_clock_init (not openrisc_sim_init).
Paolo
- Re: [RFC PATCH 21/35] hw/lm32/lm32_hwsetup: Emit warning when old code is used, (continued)
- [RFC PATCH 20/35] hw/intc/i8259: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 22/35] hw/m68k/mcf520x: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 24/35] hw/misc/cbus: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 23/35] hw/misc/applesmc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 25/35] hw/nvram/eeprom93xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 26/35] hw/openrisc/cputimer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 26/35] hw/openrisc/cputimer: Emit warning when old code is used,
Paolo Bonzini <=
- [RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 29/35] hw/ppc/ppc_booke: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 28/35] hw/ppc/ppc4xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 30/35] hw/ppc/virtex_ml507: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 31/35] hw/sh4: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 32/35] hw/riscv: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08