[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RESEND v3 32/58] auxbus: New aux_bus_realize(), pairing with aux_
From: |
Markus Armbruster |
Subject: |
[PATCH RESEND v3 32/58] auxbus: New aux_bus_realize(), pairing with aux_bus_init() |
Date: |
Wed, 10 Jun 2020 07:32:21 +0200 |
aux_bus_init() encapsulates the creation of an aux-bus and its
aux-to-i2c-bridge device.
Create aux_bus_realize() to similarly encapsulate their realization.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
include/hw/misc/auxbus.h | 7 +++++++
hw/display/xlnx_dp.c | 2 +-
hw/misc/auxbus.c | 5 +++++
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/include/hw/misc/auxbus.h b/include/hw/misc/auxbus.h
index 5cfd7a9284..0d849d9d89 100644
--- a/include/hw/misc/auxbus.h
+++ b/include/hw/misc/auxbus.h
@@ -93,6 +93,13 @@ struct AUXSlave {
*/
AUXBus *aux_bus_init(DeviceState *parent, const char *name);
+/**
+ * aux_bus_realize: Realize an AUX bus.
+ *
+ * @bus: The AUX bus.
+ */
+void aux_bus_realize(AUXBus *bus);
+
/*
* aux_request: Make a request on the bus.
*
diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
index 31d0c5a101..a714cf8a50 100644
--- a/hw/display/xlnx_dp.c
+++ b/hw/display/xlnx_dp.c
@@ -1266,7 +1266,7 @@ static void xlnx_dp_realize(DeviceState *dev, Error
**errp)
DisplaySurface *surface;
struct audsettings as;
- qdev_init_nofail(DEVICE(s->aux_bus->bridge));
+ aux_bus_realize(s->aux_bus);
qdev_init_nofail(DEVICE(s->dpcd));
aux_map_slave(AUX_SLAVE(s->dpcd), 0x0000);
diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c
index 2e1c27e842..113f4278aa 100644
--- a/hw/misc/auxbus.c
+++ b/hw/misc/auxbus.c
@@ -81,6 +81,11 @@ AUXBus *aux_bus_init(DeviceState *parent, const char *name)
return bus;
}
+void aux_bus_realize(AUXBus *bus)
+{
+ qdev_init_nofail(DEVICE(bus->bridge));
+}
+
void aux_map_slave(AUXSlave *aux_dev, hwaddr addr)
{
DeviceState *dev = DEVICE(aux_dev);
--
2.26.2
- [PATCH RESEND v3 10/58] qdev: Convert uses of qdev_create() manually, (continued)
- [PATCH RESEND v3 10/58] qdev: Convert uses of qdev_create() manually, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 02/58] Revert "hw/prep: realize the PCI root bus as part of the prep init", Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 19/58] isa: Convert uses of isa_create() with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 30/58] qdev: qdev_create(), qdev_try_create() are now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 22/58] ssi: ssi_auto_connect_slaves() never does anything, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 09/58] qdev: Convert uses of qdev_create() with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 26/58] usb: New usb_new(), usb_realize_and_unref(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 24/58] ssi: Convert last use of ssi_create_slave_no_init() manually, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 29/58] usb: Eliminate usb_try_create_simple(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 21/58] isa: isa_create(), isa_try_create() are now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 32/58] auxbus: New aux_bus_realize(), pairing with aux_bus_init(),
Markus Armbruster <=
- [PATCH RESEND v3 33/58] auxbus: Convert a use of qdev_set_parent_bus(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 17/58] pci: pci_create(), pci_create_multifunction() are now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 46/58] qdev: Drop qdev_realize() support for null bus, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 13/58] pci: New pci_new(), pci_realize_and_unref() etc., Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 42/58] hw/arm/armsse: Pass correct child size to sysbus_init_child_obj(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 25/58] ssi: ssi_create_slave_no_init() is now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 15/58] pci: Convert uses of pci_create() etc. with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 44/58] sysbus: New sysbus_realize(), sysbus_realize_and_unref(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 37/58] macio: Convert use of qdev_set_parent_bus(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 40/58] microbit: Tidy up sysbus_init_child_obj() @child argument, Markus Armbruster, 2020/06/10