[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 9/9] migration/ram: calculate un/encoded_size only when neede
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 9/9] migration/ram: calculate un/encoded_size only when needed. |
Date: |
Thu, 11 Jun 2020 20:05:48 +0100 |
User-agent: |
Mutt/1.14.0 (2020-05-02) |
* Mao Zhongyi (maozhongyi@cmss.chinamobile.com) wrote:
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> ---
> migration/ram.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 41cc530d9d..ca20030b64 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -910,14 +910,15 @@ static void migration_update_rates(RAMState *rs,
> int64_t end_time)
> xbzrle_counters.cache_miss_rate =
> (double)(xbzrle_counters.cache_miss -
> rs->xbzrle_cache_miss_prev) / page_count;
> rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss;
> - unencoded_size = (xbzrle_counters.pages - rs->xbzrle_pages_prev) *
> - TARGET_PAGE_SIZE;
> - encoded_size = xbzrle_counters.bytes - rs->xbzrle_bytes_prev;
> if (xbzrle_counters.pages == rs->xbzrle_pages_prev) {
> xbzrle_counters.encoding_rate = 0;
> - } else if (!encoded_size) {
> + } else if (xbzrle_counters.bytes == rs->xbzrle_bytes_prev) {
No, I don't think this change is worth it - this is really just the same
as 'encoded_size', and then we may as well keep the two together.
Dave
> xbzrle_counters.encoding_rate = UINT64_MAX;
> } else {
> + unencoded_size = (xbzrle_counters.pages - rs->xbzrle_pages_prev)
> *
> + TARGET_PAGE_SIZE;
> + encoded_size = xbzrle_counters.bytes - rs->xbzrle_bytes_prev;
> +
> xbzrle_counters.encoding_rate = unencoded_size / encoded_size;
> }
> rs->xbzrle_pages_prev = xbzrle_counters.pages;
> --
> 2.17.1
>
>
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PATCH 0/9] monitor/hmp-cmds: small improvements for migration, Mao Zhongyi, 2020/06/03
- [PATCH 6/9] monitor/hmp-cmds: add 'goto end' to reduce duplicate code., Mao Zhongyi, 2020/06/03
- [PATCH 5/9] monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error(), Mao Zhongyi, 2020/06/03
- [PATCH 4/9] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails, Mao Zhongyi, 2020/06/03
- [PATCH 9/9] migration/ram: calculate un/encoded_size only when needed., Mao Zhongyi, 2020/06/03
- Re: [PATCH 9/9] migration/ram: calculate un/encoded_size only when needed.,
Dr. David Alan Gilbert <=
- [PATCH 2/9] tests/migration: fix unreachable path in stress test, Mao Zhongyi, 2020/06/03
- [PATCH 7/9] monitor/hmp-cmds: improvements for the 'info migrate', Mao Zhongyi, 2020/06/03
- [PATCH 3/9] monitor/hmp-cmds: add units for migrate_parameters, Mao Zhongyi, 2020/06/03
- [PATCH 8/9] docs/xbzrle: update 'cache miss rate' and 'encoding rate' to docs, Mao Zhongyi, 2020/06/03
- [PATCH 1/9] tests/migration: mem leak fix, Mao Zhongyi, 2020/06/03