[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/22] ADB: fix autopoll issues and rework mac_via state mach
From: |
Finn Thain |
Subject: |
Re: [PATCH 00/22] ADB: fix autopoll issues and rework mac_via state machine |
Date: |
Tue, 16 Jun 2020 20:24:37 +1000 (AEST) |
Tested-by: Finn Thain <fthain@telegraphics.com.au>
Thanks for all your work on this.
I've just noticed a discrepancy between the traces from an ADB bus scan on
Laurent's Apple Quadra and an ADB bus scan on your patched QEMU machine.
Apple Q800:
[C1f][s ][Rff-][Rff ][rff-]
[C2f][s ][R61 ][R05 ][r00-]
[C3f][s ][R79 ][R01 ][r00-]
[C4f][s ][Rff-][Rff ][rff-]
[C5f][s ][Rff-][Rff ][rff-]
[C6f][s ][Rff-][Rff ][rff-]
[C7f][s ][Rff-][Rff ][rff-]
[C8f][s ][Rff-][Rff ][rff-]
[C9f][s ][Rff-][Rff ][rff-]
[Caf][s ][Rff-][Rff ][rff-]
[Cbf][s ][Rff-][Rff ][rff-]
[Ccf][s ][Rff-][Rff ][rff-]
[Cdf][s ][Rff-][Rff ][rff-]
[Cef][s ][Rff-][Rff ][rff-]
[Cff][s ][Rff-][Rff ][rff-]
QEMU Q800:
[C1f][s ][Rff-][Rff ][rff-]
[C2f][s ][R02 ][R01 ][r00-]
[C3f][s ][R03 ][R02 ][r00-]
[C4f][s ][R03-][R02 ][rff-]
[C5f][s ][R03-][R02 ][rff-]
[C6f][s ][R03-][R02 ][rff-]
[C7f][s ][R03-][R02 ][rff-]
[C8f][s ][R03-][R02 ][rff-]
[C9f][s ][R03-][R02 ][rff-]
[Caf][s ][R03-][R02 ][rff-]
[Cbf][s ][R03-][R02 ][rff-]
[Ccf][s ][R03-][R02 ][rff-]
[Cdf][s ][R03-][R02 ][rff-]
[Cef][s ][R03-][R02 ][rff-]
[Cff][s ][R03-][R02 ][rff-]
I think this could be easy to fix; it's probably just an uninitialized
packet buffer. When you come to submit v2, you may want to look into this.
- [PATCH 18/22] mac_via: move VIA1 portB write logic into mos6522_q800_via1_write(), (continued)
- [PATCH 18/22] mac_via: move VIA1 portB write logic into mos6522_q800_via1_write(), Mark Cave-Ayland, 2020/06/14
- [PATCH 20/22] adb: only call autopoll callbacks when autopoll is not blocked, Mark Cave-Ayland, 2020/06/14
- [PATCH 19/22] mac_via: rework ADB state machine to be compatible with both MacOS and Linux, Mark Cave-Ayland, 2020/06/14
- [PATCH 21/22] adb: use adb_device prefix for ADB device trace events, Mark Cave-Ayland, 2020/06/14
- [PATCH 22/22] adb: add ADB bus trace events, Mark Cave-Ayland, 2020/06/14
- Re: [PATCH 00/22] ADB: fix autopoll issues and rework mac_via state machine,
Finn Thain <=