[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Deprecate TileGX port
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] Deprecate TileGX port |
Date: |
Fri, 19 Jun 2020 18:05:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/19/20 5:51 PM, Daniel P. Berrangé wrote:
> On Fri, Jun 19, 2020 at 04:48:31PM +0100, Peter Maydell wrote:
>> Deprecate our TileGX target support:
>> * we have no active maintainer for it
>> * it has had essentially no contributions (other than tree-wide cleanups
>> and similar) since it was first added
>> * the Linux kernel dropped support in 2018, as has glibc
>>
>> Note the deprecation in the manual, but don't try to print a warning
>> when QEMU runs -- printing unsuppressable messages is more obtrusive
>> for linux-user mode than it would be for system-emulation mode, and
>> it doesn't seem worth trying to invent a new suppressible-error
>> system for linux-user just for this.
>
> Potentially we could turn it off by default in configure, so it
> requires an explicit --target-list to request it, but either way,
> I don't mind.
This is the approach I started 2 releases back... Having a
DEPRECATED_TARGET environment variable, you add your target
there and warnings are displayed. It resulted not that easy,
and 2 releases passed...
>
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> We discussed dropping this target last year:
>> https://patchew.org/QEMU/20191012071210.13632-1-philmd@redhat.com/
>> and before that in 2018, when Chen told us he didn't have time
>> to work on tilegx any more:
>> https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03955.html
>> Given that tilegx is no longer in upstream Linux I think it makes sense
>> to finally deprecate-and-drop our linux-user support for it.
>>
>> docs/system/deprecated.rst | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
>
> Regards,
> Daniel
>