[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 31/42] target/arm: Add mte helpers for sve scalar + int lo
From: |
Richard Henderson |
Subject: |
Re: [PATCH v7 31/42] target/arm: Add mte helpers for sve scalar + int loads |
Date: |
Fri, 19 Jun 2020 12:45:10 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/19/20 7:06 AM, Peter Maydell wrote:
> On Wed, 3 Jun 2020 at 02:14, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Because the elements are sequential, we can eliminate many tests all
>> at once when the tag hits TCMA, or if the page(s) are not Tagged.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
>> +static inline QEMU_ALWAYS_INLINE
>> +void sve_cont_ldst_mte_check_int(SVEContLdSt *info, CPUARMState *env,
>> + uint64_t *vg, target_ulong addr, int esize,
>> + int msize, uint32_t mtedesc, uintptr_t ra,
>> + mte_check_fn *check)
>> +{
>> + intptr_t mem_off, reg_off, reg_last;
>> +
>> + /* Process the page only if MemAttr == Tagged. */
>> + if (info->page[0].attrs.target_tlb_bit1) {
>
> It's a bit odd to use this bit here when you don't define what
> it is until patch 40. (Similarly for the next few patches.)
Perhaps. What do you suggest to resolve this?
Moving the system patches earlier?
Just defining some inline functions for self-documentation?
r~
- Re: [PATCH v7 27/42] target/arm: Add helper_mte_check_zva, (continued)
- [PATCH v7 26/42] target/arm: Implement helper_mte_checkN, Richard Henderson, 2020/06/02
- [PATCH v7 29/42] target/arm: Use mte_checkN for sve unpredicated stores, Richard Henderson, 2020/06/02
- [PATCH v7 30/42] target/arm: Use mte_check1 for sve LD1R, Richard Henderson, 2020/06/02
- [PATCH v7 31/42] target/arm: Add mte helpers for sve scalar + int loads, Richard Henderson, 2020/06/02
- [PATCH v7 32/42] target/arm: Add mte helpers for sve scalar + int stores, Richard Henderson, 2020/06/02
- [PATCH v7 34/42] target/arm: Handle TBI for sve scalar + int memory ops, Richard Henderson, 2020/06/02
- [PATCH v7 33/42] target/arm: Add mte helpers for sve scalar + int ff/nf loads, Richard Henderson, 2020/06/02
- [PATCH v7 36/42] target/arm: Complete TBI clearing for user-only for SVE, Richard Henderson, 2020/06/02
- [PATCH v7 35/42] target/arm: Add mte helpers for sve scatter/gather memory ops, Richard Henderson, 2020/06/02
- [PATCH v7 38/42] target/arm: Set PSTATE.TCO on exception entry, Richard Henderson, 2020/06/02
- [PATCH v7 37/42] target/arm: Implement data cache set allocation tags, Richard Henderson, 2020/06/02
- [PATCH v7 39/42] target/arm: Enable MTE, Richard Henderson, 2020/06/02