[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qom: Allow object_property_add_child() to fail
From: |
Auger Eric |
Subject: |
Re: [PATCH] qom: Allow object_property_add_child() to fail |
Date: |
Tue, 23 Jun 2020 18:24:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Paolo,
On 6/23/20 6:22 PM, Paolo Bonzini wrote:
> On 23/06/20 17:54, Eric Auger wrote:
>> This patch introduces two new functions, object_property_add_err() and
>> object_property_add_child_err() whose prototype features an error handle.
>> object_property_add_child_err() now gets called from user_creatable_add_type.
>> This solution was chosen instead of changing the prototype of existing
>> functions because the number of existing callers is huge.
>
> The idea is good, but I would rather name the functions
> object_property_try_add{,_child} to follow e.g. g_try_malloc.
>
> In fact, the existing function object_property_try_add can simply be
> made non-static.
Sure I will respin accordingly
Thanks
Eric
>
> Paolo
>
- [PATCH] qom: Allow object_property_add_child() to fail, Eric Auger, 2020/06/23
- Re: [PATCH] qom: Allow object_property_add_child() to fail, Daniel P . Berrangé, 2020/06/23
- Re: [PATCH] qom: Allow object_property_add_child() to fail, Paolo Bonzini, 2020/06/23
- Re: [PATCH] qom: Allow object_property_add_child() to fail, Paolo Bonzini, 2020/06/23
- Re: [PATCH] qom: Allow object_property_add_child() to fail,
Auger Eric <=
- Re: [PATCH] qom: Allow object_property_add_child() to fail, Paolo Bonzini, 2020/06/23
- Re: [PATCH] qom: Allow object_property_add_child() to fail, Markus Armbruster, 2020/06/24