[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 1/9] error: auto propagated local_err
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v10 1/9] error: auto propagated local_err |
Date: |
Wed, 24 Jun 2020 18:53:05 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Greg Kurz <groug@kaod.org> writes:
> On Mon, 15 Jun 2020 07:21:03 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Greg Kurz <groug@kaod.org> writes:
>>
>> > On Tue, 17 Mar 2020 18:16:17 +0300
>> > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
>> >
>> >> Introduce a new ERRP_AUTO_PROPAGATE macro, to be used at start of
>> >> functions with an errp OUT parameter.
>> >>
>> >> It has three goals:
>> >>
>> >> 1. Fix issue with error_fatal and error_prepend/error_append_hint: user
>> >> can't see this additional information, because exit() happens in
>> >> error_setg earlier than information is added. [Reported by Greg Kurz]
>> >>
>> >
>> > I have more of these coming and I'd really like to use ERRP_AUTO_PROPAGATE.
>> >
>> > It seems we have a consensus on the macro itself but this series is gated
>> > by the conversion of the existing code base.
>> >
>> > What about merging this patch separately so that people can start using
>> > it at least ?
>>
>> Please give me a few more days to finish the work I feel should go in
>> before the conversion. With any luck, Vladimir can then rebase /
>> recreate the conversion easily, and you can finally use the macro for
>> your own work.
>>
>
> Sure. Thanks.
Just posted "[PATCH 00/46] Less clumsy error checking". The sheer size
of the thing and the length of its dependency chain explains why it took
me so long. I feel bad about delaying you all the same. Apologies!
I hope we can converge quickly enough to get Vladimir's work on top
ready in time for the soft freeze.