[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 1/4] virtio: add vhost-user-fs-ccw device
From: |
Cornelia Huck |
Subject: |
Re: [RFC 1/4] virtio: add vhost-user-fs-ccw device |
Date: |
Thu, 25 Jun 2020 12:50:10 +0200 |
On Thu, 25 Jun 2020 12:04:27 +0200
Marc Hartmayer <mhartmay@linux.ibm.com> wrote:
> From: Halil Pasic <pasic@linux.ibm.com>
>
> Wire up the CCW device for vhost-user-fs.
>
> Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
> ---
> hw/s390x/Makefile.objs | 1 +
> hw/s390x/vhost-user-fs-ccw.c | 74 ++++++++++++++++++++++++++++++++++++
> 2 files changed, 75 insertions(+)
> create mode 100644 hw/s390x/vhost-user-fs-ccw.c
(...)
> +static void vhost_user_fs_ccw_instance_init(Object *obj)
> +{
> + VHostUserFSCcw *dev = VHOST_USER_FS_CCW(obj);
If it turns out to be a bug that pci is not forcing this to virtio-1,
you should add
ccw_dev->force_revision_1 = true;
> +
> + virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
> + TYPE_VHOST_USER_FS);
> +}
(...)
LGTM.
- [RFC 0/4] Enable virtio-fs on s390x, Marc Hartmayer, 2020/06/25
- [RFC 1/4] virtio: add vhost-user-fs-ccw device, Marc Hartmayer, 2020/06/25
- Re: [RFC 1/4] virtio: add vhost-user-fs-ccw device,
Cornelia Huck <=
- [RFC 4/4] HACK: Hard-code the libvhost-user.o-cflags for s390x, Marc Hartmayer, 2020/06/25
- [RFC 3/4] libvhost-user: handle endianness as mandated by the spec, Marc Hartmayer, 2020/06/25
- [RFC 2/4] libvhost-user: print invalid address on vu_panic, Marc Hartmayer, 2020/06/25
- Re: [RFC 0/4] Enable virtio-fs on s390x, no-reply, 2020/06/25
- Re: [RFC 0/4] Enable virtio-fs on s390x, no-reply, 2020/06/25
- Re: [RFC 0/4] Enable virtio-fs on s390x, Cornelia Huck, 2020/06/25
- Re: [RFC 0/4] Enable virtio-fs on s390x, Daniel P . Berrangé, 2020/06/25