[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 0/5] vhost-user block device backend implementation
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v9 0/5] vhost-user block device backend implementation |
Date: |
Fri, 26 Jun 2020 16:46:22 +0100 |
On Thu, Jun 25, 2020 at 08:46:56PM +0800, Coiby Xu wrote:
> On Fri, Jun 19, 2020 at 01:07:46PM +0100, Stefan Hajnoczi wrote:
> > On Mon, Jun 15, 2020 at 02:39:02AM +0800, Coiby Xu wrote:
> > > v9
> > > - move logical block size check function to a utility function
> > > - fix issues regarding license, coding style, memory deallocation, etc.
> >
> > I have replied with patches that you can consider squashing into your
> > series. I was testing this patch series and decided it was easier to
> > send code than to go back and write review comments since I was already
> > on a git branch.
> >
> > My patches can be combined into your original patches using "git rebase
> > -i" and the "fixup" or "squash" directive.
> >
> > Please add my Signed-off-by: line to affected patches when squashing
> > patches so that the git log records that I have confirmed that I have
> > permission to contribute this code.
> >
> > If you have questions about any of the patches, please let me know.
>
> Besides your Signed-off-by: line, shouldn't I also add copyright info to
> the affected files as follows?
>
> * Copyright (c) 2020 Coiby Xu <coiby.xu@gmail.com>
> *
> * Copyright (c) 2020 Red Hat, Inc., Stefan Hajnoczi <stefanha@redhat.com>
The following would be good:
* Copyright (c) 2020 Red Hat, Inc.
Thanks,
Stefan
signature.asc
Description: PGP signature