[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/core/null-machine: Do not initialize unused chardev backe
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] hw/core/null-machine: Do not initialize unused chardev backends |
|
Date: |
Fri, 26 Jun 2020 14:15:16 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/24/20 3:56 AM, Philippe Mathieu-Daudé wrote:
> The MachineClass uses an inverted logic (inherited from the
> PC machines [*]) to create the chardev backends for the default
> devices (see commits 998bbd74b9d..aa40fc9c964 and ac33f8fad14).
>
> As the none-machine doesn't have any hardware device, it is
> pointless to initialize chardev backends. Fix by setting the
> 'no_defaults' bits in its MachineClass.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/core/null-machine.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~