[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/9] i386: hvf: Set env->eip in macvm_set_rip()
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v2 1/9] i386: hvf: Set env->eip in macvm_set_rip() |
Date: |
Tue, 30 Jun 2020 14:35:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 30/06/20 12:28, Roman Bolshakov wrote:
> cpu_synchronize_state() is currently no-op for hvf but BIOS will hang in
> vAPIC option ROM when cpu_synchronize_state() is wired to
> hvf_cpu_synchronize_state().
>
> cpu_synchronize_state() state is called from vapic_write() during option
> ROM initialization. It sets dirty flag on the cpu. macvm_set_rip() is
> then invoked to advance IP after the I/O write to vAPIC port.
>
> macvm_set_rip() only modifies VMCS, it doesn't change env->eip.
> Therefore on the next iteration of vCPU loop, vcpu_dirty flag is checked
> and hvf_put_registers() overwrites correct RIP in VMCS with the value of
> env->eip that points to the I/O write instruction. Execution of the CPU
> gets stuck on the instruction.
>
> The issue can be avoided if eip doesn't contain stale value when dirty
> flag is set on cpu.
>
> Cc: Cameron Esfahani <dirty@apple.com>
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
> target/i386/hvf/vmx.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/hvf/vmx.h b/target/i386/hvf/vmx.h
> index ce2a1532d5..1e8b29bf7d 100644
> --- a/target/i386/hvf/vmx.h
> +++ b/target/i386/hvf/vmx.h
> @@ -173,6 +173,7 @@ static inline void macvm_set_rip(CPUState *cpu, uint64_t
> rip)
>
> /* BUG, should take considering overlap.. */
> wreg(cpu->hvf_fd, HV_X86_RIP, rip);
> + env->eip = rip;
>
> /* after moving forward in rip, we need to clean INTERRUPTABILITY */
> val = rvmcs(cpu->hvf_fd, VMCS_GUEST_INTERRUPTIBILITY);
>
Queued except for patch 4.
Paolo
- [PATCH v2 0/9] Improve synchronization between QEMU and HVF, Roman Bolshakov, 2020/06/30
- [PATCH v2 1/9] i386: hvf: Set env->eip in macvm_set_rip(), Roman Bolshakov, 2020/06/30
- Re: [PATCH v2 1/9] i386: hvf: Set env->eip in macvm_set_rip(),
Paolo Bonzini <=
- [PATCH v2 2/9] i386: hvf: Move synchronize functions to sysemu, Roman Bolshakov, 2020/06/30
- [PATCH v2 5/9] i386: hvf: Make long mode enter and exit clearer, Roman Bolshakov, 2020/06/30
- [PATCH v2 3/9] i386: hvf: Add hvf_cpu_synchronize_pre_loadvm(), Roman Bolshakov, 2020/06/30
- [PATCH v2 4/9] i386: hvf: Implement CPU kick, Roman Bolshakov, 2020/06/30
- [PATCH v2 8/9] i386: hvf: Clean up synchronize functions, Roman Bolshakov, 2020/06/30
- [PATCH v2 7/9] i386: hvf: Don't duplicate register reset, Roman Bolshakov, 2020/06/30
- [PATCH v2 6/9] i386: hvf: Move Guest LMA reset to macvm_set_cr0(), Roman Bolshakov, 2020/06/30