[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/21] migration: Add Error** argument to qemu_savevm_stat
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v2 05/21] migration: Add Error** argument to qemu_savevm_state_setup() |
|
Date: |
Thu, 29 Feb 2024 12:19:04 +0800 |
On Tue, Feb 27, 2024 at 07:03:29PM +0100, Cédric Le Goater wrote:
> @@ -3469,9 +3479,15 @@ static void *bg_migration_thread(void *opaque)
>
> bql_lock();
> qemu_savevm_state_header(s->to_dst_file);
> - qemu_savevm_state_setup(s->to_dst_file);
> + ret = qemu_savevm_state_setup(s->to_dst_file, &local_err);
> bql_unlock();
>
> + if (ret) {
> + migrate_set_error(s, local_err);
> + error_free(local_err);
> + goto fail;
> + }
This chunk may need to be moved above bql unlock.
> +
> qemu_savevm_wait_unplug(s, MIGRATION_STATUS_SETUP,
> MIGRATION_STATUS_ACTIVE);
>
--
Peter Xu
- [PATCH v2 17/21] vfio: Reverse test on vfio_get_dirty_bitmap(), (continued)
- [PATCH v2 17/21] vfio: Reverse test on vfio_get_dirty_bitmap(), Cédric Le Goater, 2024/02/27
- [PATCH v2 01/21] migration: Report error when shutdown fails, Cédric Le Goater, 2024/02/27
- [PATCH v2 20/21] vfio: Also trace event failures in vfio_save_complete_precopy(), Cédric Le Goater, 2024/02/27
- [PATCH v2 07/21] migration: Add Error** argument to .load_setup() handler, Cédric Le Goater, 2024/02/27
- [PATCH v2 13/21] vfio: Add Error** argument to vfio_devices_dma_logging_start(), Cédric Le Goater, 2024/02/27
- [PATCH v2 03/21] migration: Add documentation for SaveVMHandlers, Cédric Le Goater, 2024/02/27
- [PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler, Cédric Le Goater, 2024/02/27
- [PATCH v2 05/21] migration: Add Error** argument to qemu_savevm_state_setup(), Cédric Le Goater, 2024/02/27
- Re: [PATCH v2 05/21] migration: Add Error** argument to qemu_savevm_state_setup(),
Peter Xu <=
- [PATCH v2 08/21] memory: Add Error** argument to .log_global*() handlers, Cédric Le Goater, 2024/02/27
- [PATCH v2 16/21] vfio: Add Error** argument to .vfio_save_config() handler, Cédric Le Goater, 2024/02/27
- [PATCH v2 19/21] vfio: Add Error** argument to .get_dirty_bitmap() handler, Cédric Le Goater, 2024/02/27
- [PATCH v2 21/21] vfio: Extend vfio_set_migration_error() with Error* argument, Cédric Le Goater, 2024/02/27
- [PATCH v2 02/21] migration: Remove SaveStateHandler and LoadStateHandler typedefs, Cédric Le Goater, 2024/02/27
- [PATCH v2 14/21] vfio: Add Error** argument to vfio_devices_dma_logging_stop(), Cédric Le Goater, 2024/02/27
- [PATCH v2 09/21] memory: Add Error** argument to the global_dirty_log routines, Cédric Le Goater, 2024/02/27