[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_i
Re: [Qemu-ppc] [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io
Tue, 27 Mar 2012 17:23:48 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1
Am 27.03.2012 17:17, schrieb Andreas Färber:
> Am 27.03.2012 16:43, schrieb Kevin Wolf:
>> Am 27.03.2012 16:30, schrieb Andreas Färber:
>>> Am 27.03.2012 04:42, schrieb David Gibson:
>>>> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to
>>>> determine the direction of DMA it is emulating. We already have a
>>>> DMADirection enum designed specifically to encode DMA directions.
>>>> This patch uses it for dma_bdrv_io() as well. This involves removing
>>>> the DMADirection definition from the #ifdef it was inside, but since that
>>>> only existed to protect the definition of dma_addr_t from places where
>>>> config.h is not included, there wasn't any reason for it to be there in
>>>> the first place.
>>>> Cc: Kevin Wolf <address@hidden>
>>>> Signed-off-by: David Gibson <address@hidden>
>>> Including for ppc macio in absence of Alex,
>>> Reviewed-by: Andreas Färber <address@hidden>
>>> (Expecting this to go through IDE/Kevin's tree.)
>> So this isn't part of another series any more?
> AFAICS it's a single patch on qemu-devel, split out of one of the
> "Various fixes David has piled up" series on Alex' suggestion.
Okay. I don't have the time to check the details myself, but two
Reviewed-bys are enough, so I just applied it to the block branch.