[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] qemu-ga: generate missing stubs for fsfreeze
|
From: |
Luiz Capitulino |
|
Subject: |
Re: [Qemu-ppc] [PATCH] qemu-ga: generate missing stubs for fsfreeze |
|
Date: |
Tue, 17 Apr 2012 11:44:39 -0300 |
On Fri, 13 Apr 2012 21:07:36 -0500
Michael Roth <address@hidden> wrote:
> When linux-specific commands (including guest-fsfreeze-*) were consolidated
> under defined(__linux__), we forgot to account for the case where
> defined(__linux__) && !defined(FIFREEZE). As a result stubs are no longer
> being generated on linux hosts that don't have FIFREEZE support. Fix
> this.
>
> Signed-off-by: Michael Roth <address@hidden>
Looks good to me, but I'm honestly a bit confused with the number of ifdefs we
have in this file. I think it's possible to re-organize them, but maybe it's
best to move the linux specific stuff to its own file.