[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH] Bug fix for #986241: spell env corre
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH] Bug fix for #986241: spell env correctly |
Date: |
Sun, 22 Apr 2012 21:06:57 +0100 |
On 22 April 2012 20:56, Andreas Färber <address@hidden> wrote:
> Commit ed120055c7f9b26b5707d3ceabbe5a3f06aaf937 (Implement PAPR VPA
> functions for pSeries shared processor partitions) introduced the
> register_dtl() function and typo "emv" as name of its argument.
> This went unnoticed because the code in that function can access the
> global variable "env" so that no build failure resulted.
>
> Fix the argument to read "env". Resolves LP#986241.
Incidentally, I had a quick look through that file and couldn't
see any uses of 'env' outside of functions which pass it in --
is it possible to drop the dyngen-exec.h include altogether?
-- PMM