[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targ
From: |
li guang |
Subject: |
Re: [Qemu-ppc] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets |
Date: |
Wed, 24 Apr 2013 15:40:22 +0800 |
在 2013-04-24三的 08:36 +0100,Peter Maydell写道:
> On 24 April 2013 08:32, li guang <address@hidden> wrote:
> > I think even others want to use something like you said,
> > it should not 'cs_base', or, it's a bad name.
>
> Yes, this is why I said "has a less than helpful name".
>
> >>
> >> >> > --- a/target-sparc/cpu.h
> >> >> > +++ b/target-sparc/cpu.h
> >> >> > @@ -715,7 +715,7 @@ trap_state* cpu_tsptr(CPUSPARCState* env);
> >> >> > #define TB_FLAG_AM_ENABLED (1 << 5)
> >> >> >
> >> >> > static inline void cpu_get_tb_cpu_state(CPUSPARCState *env,
> >> >> > target_ulong *pc,
> >> >> > - target_ulong *cs_base, int
> >> >> > *flags)
> >> >> > + int *flags)
> >> >> > {
> >> >> > *pc = env->pc;
> >> >> > *cs_base = env->npc;
>
> >> You clearly have a problem with your compile and test
> >> process then, because it is clear from the patch that
> >> you've removed the cs_base argument from this function
> >> but the function still has a use of 'cs_base' in it.
> >
> > ???, sorry, where do I miss 'cs_base' removing?
>
> Last quoted line of source: "*cs_base = env->npc".
OK, thanks!
that remove by overshoot script!
- [Qemu-ppc] [PATCH 1/2] cpu-exec: rid cs_base of TranslationBlock, liguang, 2013/04/24
- [Qemu-ppc] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets, liguang, 2013/04/24
- Re: [Qemu-ppc] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets, Peter Maydell, 2013/04/24
- Re: [Qemu-ppc] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets, li guang, 2013/04/24
- Re: [Qemu-ppc] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets, Peter Maydell, 2013/04/24
- Re: [Qemu-ppc] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets, li guang, 2013/04/24
- Re: [Qemu-ppc] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets, Peter Maydell, 2013/04/24
- Re: [Qemu-ppc] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets,
li guang <=
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets, Andreas Färber, 2013/04/24
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets, Aurelien Jarno, 2013/04/24
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets, Andreas Färber, 2013/04/24
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets, li guang, 2013/04/24
Re: [Qemu-ppc] [PATCH 1/2] cpu-exec: rid cs_base of TranslationBlock, Paolo Bonzini, 2013/04/24